[storybook/ui] add react16 to peerdeps

[brucewpaul]

It seems as though there are a some things holding back adding react 16 as a peerdep to storybook/ui. Here is what's needed from what we can tell:

react-modal

• currently at 2.4.1, needs to be bumped to ^3.0.0

react-komposer

• PR is out to support react16 as peerdep React 16 peerDependencies fix arunoda/react-komposer#169) but has not been merged in

react-treebeard

• PR has been merged in (Add React 16 to peerDependencies storybook-eol/react-treebeard#102), but has not released

[email protected] (required by manta-core as well)

• seems like it's not being actively maintained

[email protected] (required by react-komposer as well)

• seems like it's not being actively maintained

Is it feasible to move away from react-stubber/react-simple-di so that the road to expanding the peerDependencies is clearer?

[brucewpaul]

seems like forks were made for react-simple-di and mantra-core (kadirahq/react-simple-di#12 (comment)) that, if used, would help

[Hypnosphi]

Please feel free to open PRs for updating react-modal and react-treebeard (as soon as it gets released).

@ndelangen I think we have to migrate from mantra/podda/komposer stack to something more actively maintained (like redux or mobx). What do you think?

[brucewpaul]

@Hypnosphi will do

I would also be interested in helping out with this effort as storybook/ui is our last dependency holding us back from upgrading to react16

[ndelangen]

@ndelangen I think we have to migrate from mantra/podda/komposer stack to something more actively maintained (like redux or mobx). What do you think?

Yes, although I wonder if we even have a use-case for a state management library to begin with?

[Hypnosphi]

We kinda have one, because we have external actions (from addons)

[mperrotti]

I have a pre-commit hook that runs yarn check, so I'm unable to submit new work for PR after upgrading to the latest Storybook.
Any recommendations for how to get around these issues in the short-term? Sadly, --no-verify isn't an option :(

[Hypnosphi]

in the short-term

I'm sorry but we have to admit that there's no quick solution here

UPD: oh, looks like there is one: #2303 (comment)

[danielduan]

I'm going to close this since #2314 on 3.2.16 should fix the last of the dependencies on the list here. Let me know if it doesn't.

[Hypnosphi]

Any recommendations for how to get around these issues in the short-term

@mperrotti Can you please try 3.2.16 release? We removed the react version conflicts, so probably all you'll need to do will be add some dependencies like prop-types in your project

[mperrotti]

@Hypnosphi - that takes care of the issues. Thank you!