Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: The option to have daily subscription renewals needs to be disabled #16

Open
JarrydLong opened this issue Apr 9, 2020 · 3 comments

Comments

@JarrydLong
Copy link
Contributor

CCBill doesn't seem to support this interval

@ideadude
Copy link
Member

ideadude commented Mar 3, 2021

A work around is to do one time payments that expire in 1 day or X hours (when granular expirations is launched for PMPro core).

@ideadude ideadude closed this as completed Mar 3, 2021
@ideadude ideadude reopened this Mar 3, 2021
@ideadude
Copy link
Member

ideadude commented Mar 3, 2021

We should warn people if they set up a level that renews every day.

There is no filter to remove billing periods from the dropdowns. Our solution is to add a function to check levels for compatibility and throw errors in the admin.

Here's the code in the PayFast gateway that does this: https://github.com/strangerstudios/pmpro-payfast/blob/dev/pmpro-payfast.php#L59-L89

@ideadude
Copy link
Member

ideadude commented Mar 3, 2021

Let's also detect if a "Custom Trial" is used and show an error for that.

You CAN have an initial payment different from the recurring amount, but you can't have tiered "custom" trials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants