Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add permissions to the release workflow #18

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: add permissions to the release workflow #18

merged 1 commit into from
Oct 4, 2024

Conversation

Bassel17
Copy link
Member

@Bassel17 Bassel17 commented Oct 4, 2024

What does it do?

adds write permissions

Why is it needed?

The automated release is failing because of a permission issue it seems

How to test it?

  • merge and see if the auto release will work
  • either way it's better to have the permissions specified

@Bassel17 Bassel17 added the pr: chore Cleanups / dependencies / tooling / styling label Oct 4, 2024
@Bassel17 Bassel17 requested a review from innerdvations October 4, 2024 13:14
@Bassel17 Bassel17 self-assigned this Oct 4, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 0292c11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

innerdvations
innerdvations approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yeah, I remember this from @strapi/sdk-plugin now

@Bassel17 Bassel17 merged commit 30cdcf1 into main Oct 4, 2024
3 checks passed
@Bassel17 Bassel17 deleted the fix/auto-release-not-working branch October 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

Assignees

@Bassel17 Bassel17

Labels
pr: chore Cleanups / dependencies / tooling / styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bassel17 @innerdvations