From 375a0f153f0760fc6abdcf015bbe11e6bcd90b8a Mon Sep 17 00:00:00 2001 From: Matthieu Vachon <matt@streamingfast.io> Date: Thu, 9 Nov 2023 15:34:40 -0500 Subject: [PATCH] Removed `substreams-rpc-X` flag that were there by mistake --- CHANGELOG.md | 10 ++++++++-- substreams_common.go | 3 --- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 985b244..62cd6ff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,16 +18,22 @@ If you were at `firehose-core` version `1.0.0` and are bumping to `1.1.0`, you s * Filesource validation of block order in merged-blocks now works correctly when using indexes in firehose `Blocks` queries +### Removed + +* Flag `substreams-rpc-endpoints` removed, this was present by mistake and unused actually. +* Flag `substreams-rpc-cache-store-url` removed, this was present by mistake and unused actually. +* Flag `substreams-rpc-cache-chunk-size` removed, this was present by mistake and unused actually. + ## v0.2.1 ### Operators > [!IMPORTANT] > We have had reports of older versions of this software creating corrupted merged-blocks-files (with duplicate or extra out-of-bound blocks) -> This release adds additional validation of merged-blocks to prevent serving duplicate blocks from the firehose or substreams service. +> This release adds additional validation of merged-blocks to prevent serving duplicate blocks from the firehose or substreams service. > This may cause service outage if you have produced those blocks or downloaded them from another party who was affected by this bug. -* Find the affected files by running the following command (can be run multiple times in parallel, over smaller ranges) +* Find the affected files by running the following command (can be run multiple times in parallel, over smaller ranges) ``` tools check merged-blocks-batch <merged-blocks-store> <start> <stop> diff --git a/substreams_common.go b/substreams_common.go index 17f6e67..3e5f73d 100644 --- a/substreams_common.go +++ b/substreams_common.go @@ -17,9 +17,6 @@ func registerCommonSubstreamsFlags(cmd *cobra.Command) { cmd.Flags().Uint64("substreams-state-bundle-size", uint64(1_000), "Interval in blocks at which to save store snapshots and output caches") cmd.Flags().String("substreams-state-store-url", "{sf-data-dir}/localdata", "where substreams state data are stored") cmd.Flags().String("substreams-state-store-default-tag", "", "If non-empty, will be appended to {substreams-state-store-url} (ex: 'v1'). Can be overriden per-request with 'X-Sf-Substreams-Cache-Tag' header") - cmd.Flags().StringArray("substreams-rpc-endpoints", nil, "Remote endpoints to contact to satisfy Substreams 'eth_call's") - cmd.Flags().String("substreams-rpc-cache-store-url", "{sf-data-dir}/rpc-cache", "where rpc cache will be store call responses") - cmd.Flags().Uint64("substreams-rpc-cache-chunk-size", uint64(1_000), "RPC cache chunk size in block") }) }