Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ethabi 18.0.0 in substreams-ethereum #17

Open
maoueh opened this issue Mar 15, 2023 · 1 comment
Open

Update to ethabi 18.0.0 in substreams-ethereum #17

maoueh opened this issue Mar 15, 2023 · 1 comment

Comments

@maoueh
Copy link
Collaborator

maoueh commented Mar 15, 2023

We should update to version 18.0.0 (https://github.com/rust-ethereum/ethabi/blob/master/CHANGELOG.md#1800---2022-11-16) of ethabi, it comes with speed up improvements around the encoder which will speed up eth_call creation as well as some fixes around nested tuples.

@maoueh
Copy link
Collaborator Author

maoueh commented Mar 21, 2023

It's important to note that everyone using the ABI generator feature currently needs to add an import ethabi = "17" in their Cargo.toml for code to compile properly.

This means that bumping to 18.0.0 will required when bumping to 0.x.0 (because bumping ethabi is a breaking change) will require to also bump their ethabi version. This will need to be super clear in the upgrade instructions of the release (and of course in the changelog).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant