Skip to content

Commit

Permalink
Replace removed tolerate-unready-endpoints annotation with publishNot…
Browse files Browse the repository at this point in the history
…ReadyAddresses (#1066)

Use publishNotReadyAddresses instead of tolerate-unready-endpoints annotation that got removed in k8s 1.24

- service.alpha.kubernetes.io/tolerate-unready-endpoints was removed in k8s 1.24
  with commit kubernetes/kubernetes@ae9f117

Co-authored-by: Eric Shen <[email protected]>
  • Loading branch information
lhotari and ericsyh authored Aug 9, 2023
1 parent 88f836d commit 9e94e40
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ spec:
port: {{ .Values.zookeeper.ports.clientTls }}
{{- end }}
clusterIP: None
publishNotReadyAddresses: true
selector:
{{- include "pulsar.matchLabels" . | nindent 4 }}
component: {{ .Values.zookeeper.customTools.backup.component }}
Expand Down
1 change: 1 addition & 0 deletions charts/pulsar/templates/zookeeper/zookeeper-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ spec:
port: {{ .Values.zookeeper.ports.clientTls }}
{{- end }}
clusterIP: None
publishNotReadyAddresses: true
selector:
{{- include "pulsar.matchLabels" . | nindent 4 }}
component: {{ .Values.zookeeper.component }}
Expand Down
6 changes: 2 additions & 4 deletions charts/pulsar/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,7 @@ zookeeper:
## templates/zookeeper-service.yaml
##
service:
annotations:
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
annotations: {}
## Zookeeper PodDisruptionBudget
## templates/zookeeper-pdb.yaml
##
Expand Down Expand Up @@ -857,8 +856,7 @@ bookkeeper:
## templates/bookkeeper-service.yaml
##
service:
annotations:
publishNotReadyAddresses: "true"
annotations: {}
## Bookkeeper PodDisruptionBudget
## templates/bookkeeper-pdb.yaml
##
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ spec:
port: {{ .Values.zookeeper.ports.clientTls }}
{{- end }}
clusterIP: None
publishNotReadyAddresses: true
selector:
{{- include "pulsar.matchLabels" . | nindent 4 }}
component: {{ .Values.zookeeper.customTools.backup.component }}
Expand Down
3 changes: 1 addition & 2 deletions charts/sn-platform-slim/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -701,8 +701,7 @@ zookeeper:
## templates/zookeeper-service.yaml
##
service:
annotations:
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
annotations: {}
customTools:
serviceAccount:
use: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ spec:
port: {{ .Values.zookeeper.ports.clientTls }}
{{- end }}
clusterIP: None
publishNotReadyAddresses: true
selector:
{{- include "pulsar.matchLabels" . | nindent 4 }}
component: {{ .Values.zookeeper.customTools.backup.component }}
Expand Down
3 changes: 1 addition & 2 deletions charts/sn-platform/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -776,8 +776,7 @@ zookeeper:
## templates/zookeeper-service.yaml
##
service:
annotations:
service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
annotations: {}
customTools:
serviceAccount:
use: true
Expand Down

0 comments on commit 9e94e40

Please sign in to comment.