From 0aabfbc9117ab35ffda1aa799c80271113169311 Mon Sep 17 00:00:00 2001 From: ericsyh Date: Thu, 3 Aug 2023 23:18:28 +0800 Subject: [PATCH 1/8] upgrade to use pulsar 3.0 on sn-platform Signed-off-by: ericsyh --- charts/sn-platform/values.yaml | 40 +++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index 7ff72f099..14096eebd 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -130,22 +130,22 @@ monitoring: images: zookeeper: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent customTools: backup: repository: "streamnative/pulsar-metadata-tool" - tag: "2.10.4.7" + tag: "3.0.0.4" restore: repository: "streamnative/pulsar-metadata-tool" - tag: "2.10.4.7" + tag: "3.0.0.4" bookie: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent presto: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent exporter: repository: bitnami/jmx-exporter @@ -154,36 +154,36 @@ images: # NOTE: allow overriding the presto worker image # presto_worker: # repository: streamnative/sn-platform - # tag: 2.10.4.7 + # tag: 3.0.0.4 # pullPolicy: IfNotPresent autorecovery: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent broker: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent proxy: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent pulsar_detector: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent functions: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent function_worker: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent # NOTE: allow overriding the toolset image toolset: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent kafka: repository: confluentinc/cp-kafka @@ -239,7 +239,7 @@ images: pullPolicy: IfNotPresent pulsar_metadata: repository: streamnative/sn-platform - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent configmapReload: repository: jimmidyson/configmap-reload @@ -986,7 +986,9 @@ bookkeeper: extraOptions: [] gcLoggingOptions: [] custom: {} - configData: {} + configData: + # Enable DirectIO by default + PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" ## Operator Controller ## templates/bookkeeper-cluster.yaml operator: @@ -1253,6 +1255,14 @@ broker: managedLedgerDefaultAckQuorum: "2" PULSAR_PREFIX_systemTopicEnabled: "true" PULSAR_PREFIX_topicLevelPoliciesEnabled: "true" + # Enable the new delayed message + delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" + # Enable transaction buffer segmented snapshot + transactionBufferSegmentedSnapshotEnabled: "true" + transactionBufferSnapshotSegmentSize: "262144" + # Enable the new Load Balancer + loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" + loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" ### Broker service account ## templates/broker-service-account.yaml # deprecated: use `serviceAccount` section to configure service account. From 83b243ff6dc8d624f053be45a420551ba07093aa Mon Sep 17 00:00:00 2001 From: ericsyh Date: Thu, 3 Aug 2023 23:22:06 +0800 Subject: [PATCH 2/8] upgrade pulsar to 3.0 on slim chart Signed-off-by: ericsyh --- charts/sn-platform-slim/values.yaml | 41 ++++++++++++++++------------- charts/sn-platform/values.yaml | 5 ---- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml index 95a7f7fbb..b9fe10258 100644 --- a/charts/sn-platform-slim/values.yaml +++ b/charts/sn-platform-slim/values.yaml @@ -120,47 +120,47 @@ monitoring: images: zookeeper: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent customTools: backup: repository: "streamnative/pulsar-metadata-tool" - tag: "2.10.4.7" + tag: "3.0.0.4" restore: repository: "streamnative/pulsar-metadata-tool" - tag: "2.10.4.7" + tag: "3.0.0.4" bookie: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent autorecovery: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent broker: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent proxy: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent pulsar_detector: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent functions: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent function_worker: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent # NOTE: allow overriding the toolset image toolset: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent busybox: repository: busybox @@ -193,7 +193,7 @@ images: pullPolicy: "IfNotPresent" pulsar_metadata: repository: streamnative/sn-platform-slim - tag: "2.10.4.7" + tag: "3.0.0.4" pullPolicy: IfNotPresent configmapReload: repository: jimmidyson/configmap-reload @@ -911,7 +911,9 @@ bookkeeper: extraOptions: [] gcLoggingOptions: [] custom: {} - configData: {} + configData: + # Enable DirectIO by default + PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" ## Operator Controller ## templates/bookkeeper-cluster.yaml operator: @@ -1168,16 +1170,19 @@ broker: extraOptions: [] gcLoggingOptions: [] configData: - # @deprecated: - # 1. You can use a service account to assume an IAM role to access S3 bucket - # 2. You can use a k8s secret to reference AWS credentials. See `offload.s3.secret` - # AWS_ACCESS_KEY_ID: "[YOUR AWS ACCESS KEY ID]" - # AWS_SECRET_ACCESS_KEY: "[YOUR SECRET]" managedLedgerDefaultEnsembleSize: "3" managedLedgerDefaultWriteQuorum: "3" managedLedgerDefaultAckQuorum: "2" PULSAR_PREFIX_systemTopicEnabled: "true" PULSAR_PREFIX_topicLevelPoliciesEnabled: "true" + # Enable the new delayed message + delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" + # Enable transaction buffer segmented snapshot + transactionBufferSegmentedSnapshotEnabled: "true" + transactionBufferSnapshotSegmentSize: "262144" + # Enable the new Load Balancer, not suggest to enable and use now. + loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" + loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" ### Broker service account ## templates/broker-service-account.yaml # deprecated: use `serviceAccount` section to configure service account. diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index 14096eebd..6124d553d 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -1245,11 +1245,6 @@ broker: extraOptions: [] gcLoggingOptions: [] configData: - # @deprecated: - # 1. You can use a service account to assume an IAM role to access S3 bucket - # 2. You can use a k8s secret to reference AWS credentials. See `offload.s3.secret` - # AWS_ACCESS_KEY_ID: "[YOUR AWS ACCESS KEY ID]" - # AWS_SECRET_ACCESS_KEY: "[YOUR SECRET]" managedLedgerDefaultEnsembleSize: "3" managedLedgerDefaultWriteQuorum: "3" managedLedgerDefaultAckQuorum: "2" From 60a17d935b768b6c7d513f92ebeb0bc89ebabfdd Mon Sep 17 00:00:00 2001 From: ericsyh Date: Thu, 3 Aug 2023 23:26:07 +0800 Subject: [PATCH 3/8] update example Signed-off-by: ericsyh --- examples/sn-platform/values-pulsar-3.0.yaml | 23 ++++++++++----------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/examples/sn-platform/values-pulsar-3.0.yaml b/examples/sn-platform/values-pulsar-3.0.yaml index 61ab2bbd2..6f79a16c4 100644 --- a/examples/sn-platform/values-pulsar-3.0.yaml +++ b/examples/sn-platform/values-pulsar-3.0.yaml @@ -19,32 +19,32 @@ images: zookeeper: - tag: "3.0.0.1" + tag: "3.0.0.4" bookie: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" autorecovery: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" broker: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" proxy: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" pulsar_detector: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" pullPolicy: IfNotPresent functions: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" function_worker: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" toolset: repository: streamnative/sn-platform - tag: "3.0.0.1" + tag: "3.0.0.4" zookeeper: jvm: @@ -90,9 +90,8 @@ broker: PULSAR_PREFIX_systemTopicEnabled: "true" PULSAR_PREFIX_topicLevelPoliciesEnabled: "true" # Enable the new Load Balancer, not suggest to enable and use now. - # Wait for https://github.com/apache/pulsar/pull/20528, https://github.com/apache/pulsar/pull/20525 release for fix. - # loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" - # loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" + loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" + loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" # Enable the new delayed message delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot From f980a1fae5565bfab4cab1dc1f2033e2a6a7c30e Mon Sep 17 00:00:00 2001 From: ericsyh Date: Thu, 10 Aug 2023 09:41:30 +0800 Subject: [PATCH 4/8] disable direct io Signed-off-by: ericsyh --- charts/sn-platform-slim/values.yaml | 6 +++--- charts/sn-platform/values.yaml | 6 +++--- examples/sn-platform/values-pulsar-3.0.yaml | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml index b9fe10258..a2283e87d 100644 --- a/charts/sn-platform-slim/values.yaml +++ b/charts/sn-platform-slim/values.yaml @@ -911,9 +911,9 @@ bookkeeper: extraOptions: [] gcLoggingOptions: [] custom: {} - configData: - # Enable DirectIO by default - PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" + configData: {} + # For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 + # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" ## Operator Controller ## templates/bookkeeper-cluster.yaml operator: diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index 6124d553d..d6f06bdf5 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -986,9 +986,9 @@ bookkeeper: extraOptions: [] gcLoggingOptions: [] custom: {} - configData: - # Enable DirectIO by default - PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" + configData: {} + # For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 + # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" ## Operator Controller ## templates/bookkeeper-cluster.yaml operator: diff --git a/examples/sn-platform/values-pulsar-3.0.yaml b/examples/sn-platform/values-pulsar-3.0.yaml index 6f79a16c4..9bab7730d 100644 --- a/examples/sn-platform/values-pulsar-3.0.yaml +++ b/examples/sn-platform/values-pulsar-3.0.yaml @@ -62,9 +62,9 @@ zookeeper: -Dzookeeper.forceSync=no bookkeeper: - configData: - # Enable DirectIO by default - PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" + configData: {} + # For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 + # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" jvm: gcOptions: - > From 1e5413a0e9f077a88fa07552844a51d5236b727b Mon Sep 17 00:00:00 2001 From: ericsyh Date: Fri, 11 Aug 2023 13:36:10 +0800 Subject: [PATCH 5/8] remove transactionBufferSnapshotSegmentSize Signed-off-by: ericsyh --- charts/sn-platform-slim/values.yaml | 1 - charts/sn-platform/values.yaml | 1 - examples/sn-platform/values-pulsar-3.0.yaml | 1 - 3 files changed, 3 deletions(-) diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml index a2283e87d..3a670bc99 100644 --- a/charts/sn-platform-slim/values.yaml +++ b/charts/sn-platform-slim/values.yaml @@ -1179,7 +1179,6 @@ broker: delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot transactionBufferSegmentedSnapshotEnabled: "true" - transactionBufferSnapshotSegmentSize: "262144" # Enable the new Load Balancer, not suggest to enable and use now. loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index d6f06bdf5..f489e1759 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -1254,7 +1254,6 @@ broker: delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot transactionBufferSegmentedSnapshotEnabled: "true" - transactionBufferSnapshotSegmentSize: "262144" # Enable the new Load Balancer loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" diff --git a/examples/sn-platform/values-pulsar-3.0.yaml b/examples/sn-platform/values-pulsar-3.0.yaml index 9bab7730d..36c5e608d 100644 --- a/examples/sn-platform/values-pulsar-3.0.yaml +++ b/examples/sn-platform/values-pulsar-3.0.yaml @@ -96,7 +96,6 @@ broker: delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot transactionBufferSegmentedSnapshotEnabled: "true" - transactionBufferSnapshotSegmentSize: "262144" jvm: gcOptions: - > From f33535cfd3cc1bac723f255f7752801e8102c1df Mon Sep 17 00:00:00 2001 From: ericsyh Date: Fri, 11 Aug 2023 14:57:51 +0800 Subject: [PATCH 6/8] don't enable the new LB by default Signed-off-by: ericsyh --- charts/sn-platform-slim/values.yaml | 7 ++++--- charts/sn-platform/values.yaml | 7 ++++--- examples/sn-platform/values-pulsar-3.0.yaml | 7 ++++--- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml index 3a670bc99..c1546f9cf 100644 --- a/charts/sn-platform-slim/values.yaml +++ b/charts/sn-platform-slim/values.yaml @@ -1179,9 +1179,10 @@ broker: delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot transactionBufferSegmentedSnapshotEnabled: "true" - # Enable the new Load Balancer, not suggest to enable and use now. - loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" - loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" + # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. + # Mix of new and previous Load Balancer in the same cluster will lead to unexpected problems. + # loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" + # loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" ### Broker service account ## templates/broker-service-account.yaml # deprecated: use `serviceAccount` section to configure service account. diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index f489e1759..0cf4d3d06 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -1254,9 +1254,10 @@ broker: delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot transactionBufferSegmentedSnapshotEnabled: "true" - # Enable the new Load Balancer - loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" - loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" + # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. + # Mix of new and previous Load Balancer in the same cluster will lead to unexpected problems. + # loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" + # loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" ### Broker service account ## templates/broker-service-account.yaml # deprecated: use `serviceAccount` section to configure service account. diff --git a/examples/sn-platform/values-pulsar-3.0.yaml b/examples/sn-platform/values-pulsar-3.0.yaml index 36c5e608d..c841adca1 100644 --- a/examples/sn-platform/values-pulsar-3.0.yaml +++ b/examples/sn-platform/values-pulsar-3.0.yaml @@ -89,9 +89,10 @@ broker: managedLedgerDefaultAckQuorum: "2" PULSAR_PREFIX_systemTopicEnabled: "true" PULSAR_PREFIX_topicLevelPoliciesEnabled: "true" - # Enable the new Load Balancer, not suggest to enable and use now. - loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" - loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" + # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. + # loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" + # loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" + # Enable the new delayed message delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot From 3c92573bbaa1ace7b96294906d2fb8acd73d7e0e Mon Sep 17 00:00:00 2001 From: ericsyh Date: Tue, 15 Aug 2023 14:30:16 +0800 Subject: [PATCH 7/8] fix lint Signed-off-by: ericsyh --- charts/sn-platform/values.yaml | 4 ++-- examples/sn-platform/values-pulsar-3.0.yaml | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index 0cf4d3d06..b69f0f035 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -1254,8 +1254,8 @@ broker: delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" # Enable transaction buffer segmented snapshot transactionBufferSegmentedSnapshotEnabled: "true" - # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. - # Mix of new and previous Load Balancer in the same cluster will lead to unexpected problems. + # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. + # Mix of new and previous Load Balancer in the same cluster will lead to unexpected problems. # loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" # loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" ### Broker service account diff --git a/examples/sn-platform/values-pulsar-3.0.yaml b/examples/sn-platform/values-pulsar-3.0.yaml index c841adca1..2db3045a7 100644 --- a/examples/sn-platform/values-pulsar-3.0.yaml +++ b/examples/sn-platform/values-pulsar-3.0.yaml @@ -89,7 +89,8 @@ broker: managedLedgerDefaultAckQuorum: "2" PULSAR_PREFIX_systemTopicEnabled: "true" PULSAR_PREFIX_topicLevelPoliciesEnabled: "true" - # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. + # Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. + # Mix of new and previous Load Balancer in the same cluster will lead to unexpected problems. # loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" # loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" From 462b4a7cbddc93ff662fec9262f71d8d85237333 Mon Sep 17 00:00:00 2001 From: ericsyh Date: Wed, 23 Aug 2023 16:10:00 +0800 Subject: [PATCH 8/8] update to fix comments Signed-off-by: ericsyh --- charts/sn-platform-slim/values.yaml | 2 +- charts/sn-platform/values.yaml | 2 +- examples/sn-platform/values-pulsar-3.0.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml index c1546f9cf..78fe3f690 100644 --- a/charts/sn-platform-slim/values.yaml +++ b/charts/sn-platform-slim/values.yaml @@ -913,7 +913,7 @@ bookkeeper: custom: {} configData: {} # For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 - # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" + # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "false" ## Operator Controller ## templates/bookkeeper-cluster.yaml operator: diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml index b69f0f035..52caf6cbb 100644 --- a/charts/sn-platform/values.yaml +++ b/charts/sn-platform/values.yaml @@ -988,7 +988,7 @@ bookkeeper: custom: {} configData: {} # For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 - # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" + # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "false" ## Operator Controller ## templates/bookkeeper-cluster.yaml operator: diff --git a/examples/sn-platform/values-pulsar-3.0.yaml b/examples/sn-platform/values-pulsar-3.0.yaml index 2db3045a7..b20869d99 100644 --- a/examples/sn-platform/values-pulsar-3.0.yaml +++ b/examples/sn-platform/values-pulsar-3.0.yaml @@ -64,7 +64,7 @@ zookeeper: bookkeeper: configData: {} # For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 - # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" + # PULSAR_PREFIX_dbStorage_directIOEntryLogger: "false" jvm: gcOptions: - >