Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detector template #1162

Merged
merged 6 commits into from
May 20, 2024
Merged

fix: detector template #1162

merged 6 commits into from
May 20, 2024

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented May 16, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Signed-off-by: ericsyh <[email protected]>
@ericsyh ericsyh requested review from a team as code owners May 16, 2024 06:24
Copy link

@ericsyh:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label May 16, 2024
ericsyh added 4 commits May 16, 2024 14:39
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Copy link

@ericsyh:Thanks for providing doc info!

@github-actions github-actions bot added no-need-doc This pr does not need any document and removed doc-info-missing This pr needs to mark a document option in description labels May 17, 2024
Signed-off-by: ericsyh <[email protected]>
@ericsyh ericsyh merged commit 45673ac into master May 20, 2024
2 checks passed
@ericsyh ericsyh deleted the fix-detector-template branch May 20, 2024 13:50
ericsyh added a commit that referenced this pull request May 24, 2024
* fix: detector template

Signed-off-by: ericsyh <[email protected]>

* update detector auth example

Signed-off-by: ericsyh <[email protected]>

* update template

Signed-off-by: ericsyh <[email protected]>

* update the template

Signed-off-by: ericsyh <[email protected]>

* update the template

Signed-off-by: ericsyh <[email protected]>

* fix the comment

Signed-off-by: ericsyh <[email protected]>

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit 45673ac)
ericsyh added a commit that referenced this pull request May 24, 2024
* fix: detector template

Signed-off-by: ericsyh <[email protected]>

* update detector auth example

Signed-off-by: ericsyh <[email protected]>

* update template

Signed-off-by: ericsyh <[email protected]>

* update the template

Signed-off-by: ericsyh <[email protected]>

* update the template

Signed-off-by: ericsyh <[email protected]>

* fix the comment

Signed-off-by: ericsyh <[email protected]>

---------

Signed-off-by: ericsyh <[email protected]>
(cherry picked from commit 45673ac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants