Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure image references in tests are properly updated by dependabot #1349

Open
MikeEdgar opened this issue Jan 9, 2025 · 0 comments · May be fixed by #1350
Open

Ensure image references in tests are properly updated by dependabot #1349

MikeEdgar opened this issue Jan 9, 2025 · 0 comments · May be fixed by #1350
Labels
java Pull requests that update Java code

Comments

@MikeEdgar
Copy link
Member

Container images used in several tests are currently hard-coded in Java classes. We should have these externalized somehow so that dependabot can update them to ensure the tests stay on current versions of the containers.

Idea 1:
Use a Maven property and a "dummy" dependency of the dependency that dependabot Maven can track for updates. This has the downside of adding a fake dependency and also tracking a version string that may differ from the actual container image tag.

Idea 2:
Add an empty Dockerfile for each image in the test resources that may be loaded and the image reference parsed for use in the tests. The Dockerfiles would be updated automatically by dependabot Docker support. This seems like a better choice than "idea 1".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant