more user testing

[matkoniecz]

previous one: #4264

For start, I improved Polish translation based on gathered feedback. I want to encourage everyone to try using StreetComplete in their own language. Or maybe look at which translations are confusing if you ever show StreetComplete to someone new, and try to improve them.

Translating can be done by anyone, see https://github.com/streetcomplete/StreetComplete/blob/master/CONTRIBUTING.md#translating-the-app

---

Location permission request appears after tutorial - maybe showing it after second screen, so quest scan can start earlier would make sense? (May be too complicated technically)

Immediately after giving location permission toast about missing location permission is shown.

---

From "users confused by something that should be clear": more people were unable to notice "can't say" or have not treated it as something clickable.

---

In some places dark blue text on dark background is appearing. Some instances of that were fixed in ac278b1 but some remain where for now I have not figured out how to fix it. And remaining ones are not for very important things, so maybe it is fine to keep it as is (entrance addressing quest in the dark mode was the worst case)

now in dark mode orange is used for all text

---

Undo menu now links mentioned keys.
Change is tiny but to be able to get to that point it took unexpectedly long time.
It required significant review of what StreetComplete is tagging, including automated and semiautomated code analysis.

And very significant and large scale improvements to general OpenStreetMap documentation on OSM Wiki. See say https://lists.openstreetmap.org/pipermail/tagging/2022-September/thread.html#65346 or https://wiki.openstreetmap.org/w/index.php?title=Template%3AMap_Features%3Asurface&type=revision&diff=2400015&oldid=2384484 and other surface-related edits or https://wiki.openstreetmap.org/w/index.php?title=Tag:surface%3Dunhewn_cobblestone&action=history https://wiki.openstreetmap.org/w/index.php?title=Tag:surface%3Dearth&action=history https://wiki.openstreetmap.org/wiki/Key:name:ceb https://wiki.openstreetmap.org/w/index.php?title=Tag:surface%3Ddirt&action=history https://wiki.openstreetmap.org/w/index.php?title=Tag:surface%3Dmud&action=history https://wiki.openstreetmap.org/w/index.php?title=Template:Map_Features:tracktype&action=history

And resulted in discovery of some issues like streetcomplete/countrymetadata#9 - and improvements also to OSM Wiki interface.

Also openstreetmap/id-tagging-schema#597 (which aims to promote value introduced initially by StreetComplete - make it understandable by people using other editors and confirm its acceptance).

And several adjacent issues.

It is really funny how high here is rate of merged code to effort, one of the highest ever for my coding (except ones that has failed).

Still, this things were doing for its own sake - not solely as enabler of this minor improvement.

For example there is a problem is with surfaces - many people are not actually able to distinguish between them and are confused. Here linking OSM Wiki (or making some short sumary based on it) may be a good idea, but to make it useful OSM Wiki needed to be first fixed.

---

#4431

---

Triggered changes to handle unexpected misuse of StreetComplete infrastructure - I made JOSM and iD developers aware of a problem of disappearing image links, JOSM has warning already and iD is planning to have one.

Also, I prepared a bot edit (it is in a discussion phase, will run it soon unless people will protest with some valid reasons for not doing it)

#4409 + openstreetmap/iD#9302 + https://josm.openstreetmap.de/ticket/22397
https://gitlab.com/matkoniecz/osm-automation/-/blob/master/recurrent%20bot%20edits/clean_temporary_links.py https://lists.openstreetmap.org/pipermail/talk/2022-September/087786.html https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/remove_temporary_files_hosted_on_westnordost.de

---

opened #4417 and streetcomplete/streetcomplete-mapstyle#138

---

#4637 is actually also result of this user testing, but was processed with a delay