Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groovy version upgrade for rest-assured #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anki2189
Copy link
Member

@carlspring
Copy link
Member

@anki2189 ,

My apologies, I've only just seen this pull request.

The version of groovy will have to be defined in the strongbox-parent, as you know. In addition, this version will have to be compatible with the issues/1649 branch. Would you like to check this on both branches?

Thanks and apologies for not reviewing this on time!

@steve-todorov
Copy link
Member

@anki2189 This change is breaking the maven integration test. Could you have another look?

@anki2189
Copy link
Member Author

@anki2189 This change is breaking the maven integration test. Could you have another look?

@steve-todorov This has to be tested with strongbox/strongbox#1701. Are we testing it with master, it will fail for master till strongbox/strongbox#1701 is not merged.

@steve-todorov
Copy link
Member

Oh, I see now. Yes, things seem to be working now in s-w-i-t, however strongbox/strongbox#1701 is still failing at the build stage. Could you check that out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants