runctl server should reject older runctl clients #73
Assignees
Labels
Comments
|
Tracked it down. Turns out it's not just sequence numbers that were added, but a whole other layer of encapsulation. The listening side of the channel in the problem scenario doesn't even get notification that a request was made because strong-control-channel just ignores the request. I'll fix this in strong-control-channel by closing the connection when a message isn't one of the known message types and release as a new major version, then rev the dependency in strong-supervisor and anywhere else it is used. |
rmg
added a commit
to strongloop/strong-control-channel
that referenced
this issue
Dec 3, 2014
Messages from older clients may not have a valid cmd, so they should be disconnected instead of left in limbo. This fixes the problem behind strongloop/strong-supervisor#73
rmg
added a commit
to strongloop/strong-control-channel
that referenced
this issue
Dec 3, 2014
Give older clients a better failure mode since we can't change them. The problem case is [email protected] will just exit immediately with no failure when connecting to a newer version. With this behaviour the client is at least notified there is an error, which will greatly improve the user experience for any future incarnations of strongloop/strong-supervisor#73
|
Will be fixed when an updated strong-control-channel is released with strongloop/strong-control-channel#10 in it. |
This was referenced Dec 3, 2014
|
expecting this to be a failure case. Not a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running
sl-runfrom [email protected] connecting withsl-runctlfrom [email protected] results in thesl-runctlcommand hanging waiting for a response.The cause is likely sequence numbers being added to the protocol in 1.1.1.
To mitigate this, the server side of the control channel should close connections that don't follow its expected protocol/format instead of silently dropping the message. This would result in an error on the
sl-runctlside instead of hanging.The text was updated successfully, but these errors were encountered: