Stop ErrorLogger from from overflowing its internal buffer #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bugfix.
On Windows (at least), the ErrorLogger didn't correctly check if its internal buffer was full, possible causing an overflow+crash.
That occurred, for example, on initialization, when the drivers directory contained a few additional DLLs which weren't OpenNI drivers. For each non-driver-DLL, an error message is stored in the ErrorLogger, without ever clearing it, quickly filling up the buffer.
This fixes that. When the buffer is full, no more messages are stored in the ErrorLogger (like it was supposed to work).