Skip to content

Commit 29d546a

Browse files
committed
Upgraded django-filter to 2.0.0
1 parent bb5c098 commit 29d546a

File tree

15 files changed

+248
-197
lines changed

15 files changed

+248
-197
lines changed

netbox/circuits/api/views.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class CircuitsFieldChoicesViewSet(FieldChoicesViewSet):
2929
class ProviderViewSet(CustomFieldModelViewSet):
3030
queryset = Provider.objects.prefetch_related('tags')
3131
serializer_class = serializers.ProviderSerializer
32-
filter_class = filters.ProviderFilter
32+
filterset_class = filters.ProviderFilter
3333

3434
@action(detail=True)
3535
def graphs(self, request, pk=None):
@@ -49,7 +49,7 @@ def graphs(self, request, pk=None):
4949
class CircuitTypeViewSet(ModelViewSet):
5050
queryset = CircuitType.objects.all()
5151
serializer_class = serializers.CircuitTypeSerializer
52-
filter_class = filters.CircuitTypeFilter
52+
filterset_class = filters.CircuitTypeFilter
5353

5454

5555
#
@@ -59,7 +59,7 @@ class CircuitTypeViewSet(ModelViewSet):
5959
class CircuitViewSet(CustomFieldModelViewSet):
6060
queryset = Circuit.objects.select_related('type', 'tenant', 'provider').prefetch_related('tags')
6161
serializer_class = serializers.CircuitSerializer
62-
filter_class = filters.CircuitFilter
62+
filterset_class = filters.CircuitFilter
6363

6464

6565
#
@@ -69,4 +69,4 @@ class CircuitViewSet(CustomFieldModelViewSet):
6969
class CircuitTerminationViewSet(ModelViewSet):
7070
queryset = CircuitTermination.objects.select_related('circuit', 'site')
7171
serializer_class = serializers.CircuitTerminationSerializer
72-
filter_class = filters.CircuitTerminationFilter
72+
filterset_class = filters.CircuitTerminationFilter

netbox/circuits/filters.py

+18-12
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,27 @@
1010

1111

1212
class ProviderFilter(CustomFieldFilterSet, django_filters.FilterSet):
13-
id__in = NumericInFilter(name='id', lookup_expr='in')
13+
id__in = NumericInFilter(
14+
field_name='id',
15+
lookup_expr='in'
16+
)
1417
q = django_filters.CharFilter(
1518
method='search',
1619
label='Search',
1720
)
1821
site_id = django_filters.ModelMultipleChoiceFilter(
19-
name='circuits__terminations__site',
22+
field_name='circuits__terminations__site',
2023
queryset=Site.objects.all(),
2124
label='Site',
2225
)
2326
site = django_filters.ModelMultipleChoiceFilter(
24-
name='circuits__terminations__site__slug',
27+
field_name='circuits__terminations__site__slug',
2528
queryset=Site.objects.all(),
2629
to_field_name='slug',
2730
label='Site (slug)',
2831
)
2932
tag = django_filters.CharFilter(
30-
name='tags__slug',
33+
field_name='tags__slug',
3134
)
3235

3336
class Meta:
@@ -54,7 +57,10 @@ class Meta:
5457

5558

5659
class CircuitFilter(CustomFieldFilterSet, django_filters.FilterSet):
57-
id__in = NumericInFilter(name='id', lookup_expr='in')
60+
id__in = NumericInFilter(
61+
field_name='id',
62+
lookup_expr='in'
63+
)
5864
q = django_filters.CharFilter(
5965
method='search',
6066
label='Search',
@@ -64,7 +70,7 @@ class CircuitFilter(CustomFieldFilterSet, django_filters.FilterSet):
6470
label='Provider (ID)',
6571
)
6672
provider = django_filters.ModelMultipleChoiceFilter(
67-
name='provider__slug',
73+
field_name='provider__slug',
6874
queryset=Provider.objects.all(),
6975
to_field_name='slug',
7076
label='Provider (slug)',
@@ -74,7 +80,7 @@ class CircuitFilter(CustomFieldFilterSet, django_filters.FilterSet):
7480
label='Circuit type (ID)',
7581
)
7682
type = django_filters.ModelMultipleChoiceFilter(
77-
name='type__slug',
83+
field_name='type__slug',
7884
queryset=CircuitType.objects.all(),
7985
to_field_name='slug',
8086
label='Circuit type (slug)',
@@ -88,24 +94,24 @@ class CircuitFilter(CustomFieldFilterSet, django_filters.FilterSet):
8894
label='Tenant (ID)',
8995
)
9096
tenant = django_filters.ModelMultipleChoiceFilter(
91-
name='tenant__slug',
97+
field_name='tenant__slug',
9298
queryset=Tenant.objects.all(),
9399
to_field_name='slug',
94100
label='Tenant (slug)',
95101
)
96102
site_id = django_filters.ModelMultipleChoiceFilter(
97-
name='terminations__site',
103+
field_name='terminations__site',
98104
queryset=Site.objects.all(),
99105
label='Site (ID)',
100106
)
101107
site = django_filters.ModelMultipleChoiceFilter(
102-
name='terminations__site__slug',
108+
field_name='terminations__site__slug',
103109
queryset=Site.objects.all(),
104110
to_field_name='slug',
105111
label='Site (slug)',
106112
)
107113
tag = django_filters.CharFilter(
108-
name='tags__slug',
114+
field_name='tags__slug',
109115
)
110116

111117
class Meta:
@@ -138,7 +144,7 @@ class CircuitTerminationFilter(django_filters.FilterSet):
138144
label='Site (ID)',
139145
)
140146
site = django_filters.ModelMultipleChoiceFilter(
141-
name='site__slug',
147+
field_name='site__slug',
142148
queryset=Site.objects.all(),
143149
to_field_name='slug',
144150
label='Site (slug)',

0 commit comments

Comments
 (0)