Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ETC as minutes or hours when applicable #956

Closed
JoshuaKGoldberg opened this issue Jul 8, 2018 · 4 comments · Fixed by #1176
Closed

Show ETC as minutes or hours when applicable #956

JoshuaKGoldberg opened this issue Jul 8, 2018 · 4 comments · Fixed by #1176
Assignees
Labels
🚀 Feature request New feature request 👶 Good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Jul 8, 2018

Summary

When on a laptop with 4 cores instead of a dev machine with 16, Stryker takes quite a bit longer for large projects:

image

Could we get this in hours instead, please?

Stryker environment

    "stryker": "0.24.1",
    "stryker-api": "0.17.2",
    "stryker-baseline-reporter": "1.0.3",
    "stryker-cli": "0.1.3",
    "stryker-html-reporter": "0.14.2",
    "stryker-jest-runner": "0.7.0",
    "stryker-typescript": "0.11.2",
    "stryker-webpack-transpiler": "0.5.1",

Your Environment

software version(s)
node 8.8
npm 5.6
Operating System Windows 10

Edit: how about using moment or luxon?

@JoshuaKGoldberg JoshuaKGoldberg changed the title Show ETC as hours when applicable Show ETC as minutes hours when applicable Jul 8, 2018
@JoshuaKGoldberg JoshuaKGoldberg changed the title Show ETC as minutes hours when applicable Show ETC as minutes or hours when applicable Jul 8, 2018
@nicojs
Copy link
Member

nicojs commented Jul 9, 2018

We could, but it wouldn't make it go faster ;).

Seems like a fair request and a good first issue for anyone interested. Thanks @JoshuaKGoldberg

@nicojs nicojs added 🚀 Feature request New feature request 👶 Good first issue Good for newcomers labels Jul 9, 2018
@nicojs
Copy link
Member

nicojs commented Jul 9, 2018

@JoshuaKGoldberg both moment and luxon are good suggestions, but both come at a cost (namely download size). Let's try to avoid them if the only thing we need is a human readable ETC.

@simondel simondel added the hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 1, 2018
@sanderkoenders
Copy link
Member

sanderkoenders commented Oct 4, 2018

It seems like this ain't as easy as we thought it would be, we are using https://github.com/visionmedia/node-progress and it does not support any other format.

As seen in this issue visionmedia/node-progress#63 there have been multiple pull-requests for this but none was accepted.

visionmedia/node-progress#69
visionmedia/node-progress#75
visionmedia/node-progress#98

@nicojs
Copy link
Member

nicojs commented Oct 4, 2018

Please upvote: visionmedia/node-progress#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature request 👶 Good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants