Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunger damages armor #119

Open
aerozoic opened this issue Aug 8, 2017 · 5 comments · Fixed by minetest-mods/3d_armor#6
Open

Hunger damages armor #119

aerozoic opened this issue Aug 8, 2017 · 5 comments · Fixed by minetest-mods/3d_armor#6

Comments

@aerozoic
Copy link

aerozoic commented Aug 8, 2017

From a logical standpoint it doesn't make sense. But i understand MT has it's limits. If i should have posted this on the hunger repo, sorry in advance!
🔶

@stujones11
Copy link
Owner

I agree it's not great, however, the core does not give any indication of what has damaged the player. Ideally I would like to handle all armor damage on punch but not all mods use the proper api to apply damage and instead set the player HP directly :(

There is an issue somewhere for including a source of damage but until that is implemented, the best the armor mod could do is expose last_punch_time though the api, that way other mods would be able to reset that for a given player, causing the HP damage to be ignored.

@aerozoic
Copy link
Author

aerozoic commented Aug 8, 2017

Thanks for your response. This is pretty much what i figured. Just thought i'd ask to be sure :)
🔶

@stujones11
Copy link
Owner

As of minetest/minetest@dfc8198 it may be possible to avoid this problem in future versions.

@orbea
Copy link
Contributor

orbea commented Apr 5, 2020

@stujones11 Any news on this issue? This also affects hunger with hunger_ng.

@orbea
Copy link
Contributor

orbea commented Apr 30, 2020

Seems it was not hard to fix.

minetest-mods#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants