(🎁) Support basedpyright

[KotlinIsland]

Basedpyright is a Pyright fork with many improvements and new features

Link: https://github.com/DetachHead/basedpyright

I would be awesome if this project could support Basedpyright

[jfcherng]

I already know this actually. It's a great awesome work. But if it gets supported, I think it should be LSP-basedpyright rather than in this repository.

LSP-basedpyright can be created with some minor modifications from LSP-pyright.

[KotlinIsland]

I think it should be LSP-basedpyright rather than in this repository.

Why is that?

[jfcherng]

I think it should be LSP-basedpyright rather than in this repository.

Why is that?

• The current implementation for all nodejs-based LSP-* just can't let the user to switch which one to install. We can install both and make the user to switch at runtime, but that makes thing unneccesary complicated imho.
  • E.g., all of your server settings replaces pyright. prefix to basedpyright.. It makes sense. But it makes thing complicated if we support both.
• If we simply replace the underlying pyright with basedpyright but still naming it as LSP-pyright, that may cause confusion.

Make a new LSP-basedpyright is far more easier and clean.

[jfcherng]

@KotlinIsland Do you think pyright has ANY benefits when it compares to basedpyright? I think we should advertise LSP-basedpyright to LSP-pyright users when LSP-basedpyright comes out.

[KotlinIsland]

Unless you consider pyright an "industry standard", then not at all. Additionally, the vision behind bpr is to keep any functionally as compliant as possible.

[jfcherng]

Hi @rchl, @rwols

Here is a working LSP-basedpyright with basedpyright v1.8.0, which basically includes all Pyright features and some exclusive Pylance features such as semantic highlighting and inlay hints.

I forget what's the procedure to move it into LSP org.

[jfcherng]

Moved to https://github.com/sublimelsp/LSP-basedpyright.

[jfcherng]

Closed as LSP-basedpyright has been merged into the LSP orgnization. It should appear on Package Control within hours: https://packagecontrol.io/packages/LSP-basedpyright