From e29883ac7797731941bb911ef4b7ec9ca2c25642 Mon Sep 17 00:00:00 2001 From: jwortmann Date: Sun, 20 Oct 2024 21:32:40 +0200 Subject: [PATCH] Make DocumentSyncListener more efficient if no server is running (#2532) --- plugin/documents.py | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/plugin/documents.py b/plugin/documents.py index a08658d0a..3c1d133fd 100644 --- a/plugin/documents.py +++ b/plugin/documents.py @@ -55,8 +55,10 @@ from .session_buffer import SessionBuffer from .session_view import SessionView from functools import partial -from typing import Any, Callable, Generator, Iterable +from functools import wraps +from typing import Any, Callable, Generator, Iterable, TypeVar from typing import cast +from typing_extensions import Concatenate, ParamSpec from weakref import WeakSet from weakref import WeakValueDictionary import itertools @@ -68,6 +70,24 @@ SUBLIME_WORD_MASK = 515 +P = ParamSpec('P') +R = TypeVar('R') + + +def requires_session( + func: Callable[Concatenate[DocumentSyncListener, P], R] +) -> Callable[Concatenate[DocumentSyncListener, P], R | None]: + """ + A decorator for the `DocumentSyncListener` event handlers, which immediately returns `None` if there are no + `SessionView`s. + """ + @wraps(func) + def wrapper(self: DocumentSyncListener, *args: P.args, **kwargs: P.kwargs) -> R | None: + if not self.session_views_async(): + return None + return func(self, *args, **kwargs) + return wrapper + def is_regular_view(v: sublime.View) -> bool: # Not from the quick panel (CTRL+P), and not a special view like a console, output panel or find-in-files panels. @@ -327,6 +347,7 @@ def session_buffers_async(self, capability: str | None = None) -> list[SessionBu def session_views_async(self) -> list[SessionView]: return list(self._session_views.values()) + @requires_session def on_text_changed_async(self, change_count: int, changes: Iterable[sublime.TextChange]) -> None: if self.view.is_primary(): for sv in self.session_views_async(): @@ -364,9 +385,12 @@ def on_activated_async(self) -> None: return if not self._registered: self._register_async() + session_views = self.session_views_async() + if not session_views: + return if userprefs().show_code_actions: self._do_code_actions_async() - for sv in self.session_views_async(): + for sv in session_views: if sv.code_lenses_needs_refresh: sv.set_code_lenses_pending_refresh(needs_refresh=False) sv.start_code_lenses_async() @@ -381,6 +405,7 @@ def on_activated_async(self) -> None: sb.set_inlay_hints_pending_refresh(needs_refresh=False) sb.do_inlay_hints_async(self.view) + @requires_session def on_selection_modified_async(self) -> None: first_region, _ = self._update_stored_selection_async() if first_region is None: @@ -482,6 +507,7 @@ def on_query_context(self, key: str, operator: int, operand: Any, match_all: boo return operand == bool(session_view.session_buffer.get_document_link_at_point(self.view, position)) return None + @requires_session def on_hover(self, point: int, hover_zone: int) -> None: if self.view.is_popup_visible(): return @@ -524,6 +550,7 @@ def _on_hover_gutter_async(self, point: int) -> None: location=point, on_navigate=lambda href: self._on_navigate(href, point)) + @requires_session def on_text_command(self, command_name: str, args: dict | None) -> tuple[str, dict] | None: if command_name == "auto_complete": self._auto_complete_triggered_manually = True @@ -539,6 +566,7 @@ def on_text_command(self, command_name: str, args: dict | None) -> tuple[str, di return ('paste', {}) return None + @requires_session def on_post_text_command(self, command_name: str, args: dict[str, Any] | None) -> None: if command_name == 'paste': format_on_paste = self.view.settings().get('lsp_format_on_paste', userprefs().lsp_format_on_paste) @@ -552,6 +580,7 @@ def on_post_text_command(self, command_name: str, args: dict[str, Any] | None) - # hide the popup when `esc` or arrows are pressed pressed self.view.hide_popup() + @requires_session def on_query_completions(self, prefix: str, locations: list[int]) -> sublime.CompletionList | None: completion_list = sublime.CompletionList() triggered_manually = self._auto_complete_triggered_manually