From e304c067b7e433858ddb9f312d418867e8a62d77 Mon Sep 17 00:00:00 2001 From: Janos Wortmann Date: Wed, 4 Dec 2024 19:12:52 +0100 Subject: [PATCH] Replace Quick-Fix label in hover popup with lightbulb icon --- icons/lightbulb_colored.png | Bin 0 -> 443 bytes icons/lightbulb_colored@2x.png | Bin 0 -> 826 bytes icons/lightbulb_colored@3x.png | Bin 0 -> 1181 bytes plugin/documents.py | 2 +- plugin/hover.py | 6 ++++-- popups.css | 3 +++ 6 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 icons/lightbulb_colored.png create mode 100644 icons/lightbulb_colored@2x.png create mode 100644 icons/lightbulb_colored@3x.png diff --git a/icons/lightbulb_colored.png b/icons/lightbulb_colored.png new file mode 100644 index 0000000000000000000000000000000000000000..fd48ab4b2d7f62592e68407fc198313b6a6f0d55 GIT binary patch literal 443 zcmV;s0Yv_ZP)2xAP>aeb3T7J!s1 zOixwkf98~l#X87OY@NxJM#@r{jR9~l(}9$gY~D|9pEvjuG{x?-!p>azqYJ>js|UDf z>bzb5^V&bh1>D|bzogzu!0aYSZeLbsJnCc{W;R%590NoDHid0w(PpXqTHDeX+8=Fp lrPe!88`yKu;&s;^{0sT2gosckajXCU002ovPDHLkV1kX-xGDeu literal 0 HcmV?d00001 diff --git a/icons/lightbulb_colored@2x.png b/icons/lightbulb_colored@2x.png new file mode 100644 index 0000000000000000000000000000000000000000..c06e86d04b36a7bbafe12e7ec0ee6d101395b4e8 GIT binary patch literal 826 zcmV-A1I7G_P)?>2 zK~zYI&6dwk9Ay~CKhMlENJxrl4Y7^kVu}H3YrJr2BsErxY1-Z8hwCaXJc`olArGhVI1^Ad^fB) z4#TOlg>Ux^3jExVu#bUMb?P^X8)o_)Gm~gD;|)aHR*4zI4e7!sb%Qqj{7FMstB`x3 zOWsOHfzi?Mp~SH!Z*pF*+H+Ea(@Dz2mT_o<6hs?+HSW5 zpy=m1z?Omiz)f#`Ul+sU!S)&tDTx|WPzcyzF2rOM4 z{Nkkxvq_K#u$dX)R{*4RZ9EFp2_UoxNzeXvNx)+DqAL+(=m3Dp*6W9CvG}9n!83^< z!4}})o0 z&>g&zX<0UYU-h~l2gNPjo3w|o%i z6$@hEa#1iMST>Wtqu96(tP0+(eTmj8_QUr$l}bt|ex5&yqu$u0(5`uXQ!9@I!U;bG zdnq=@)my;Jj|MXPO5!;KH!3VB8^j)Hc#`&LOPhZFl%ZqW=Ok7evxO`5)YrA5;unLR zgzk@#!O)I)eN)k~ZHhlfRe5T@4MhDr-1NfIoq9a}2irFeECq&h6951J07*qoM6N<$ Ef*?G6kpKVy literal 0 HcmV?d00001 diff --git a/icons/lightbulb_colored@3x.png b/icons/lightbulb_colored@3x.png new file mode 100644 index 0000000000000000000000000000000000000000..fce8930b0f980d1600de81d2fa60172247d1f6f9 GIT binary patch literal 1181 zcmV;O1Y-M%P)P6yJrpYzidHLS z4>fIi5%E$%greEFTQ+Gxqpi>$l@_rljXj7(ZHONrRkI&6^LR+I`)oj3s;0jwxZmgS?2yT1P>shq!daQSq1#j($+ z>f<40<^;W|$ghHKQDocFQm+yT7ah+}k;?tqKHPgRI+c5FeYy(Rj|!&)&!1jxrWW(* z9?P+kf*e8Fe%t8_?p^aw(SONn3$8LX{I0@5!==EO>-iZ{xpKo~fPC65+ja)@RY0nZ z;Tj=-cPKm26zVpWr$?Sg^{fFH2-?@^B56F>BI9*2!tpp@ z0Pf(#hX@(7w<6<>azf#Xh0$Jx#|+o^?!u;1alop83!B~ot{bi=7S9jg8yQX{7@&Se zPI2H&r5!j9oT-S`{aa$G4n&7j-DQ}*S0Iug9#8_T|&6WfO^69RY$nxnfOM-&HX2W}}!}nimmfC#4Q@O=JtpTau zi2IhF(VA;Hu5ZN_SP0Y_AeCEemfP|>L~(k!-%>78Tbfc}`#U~iSdLE3nsXlxD7V!CsDey;=;w8iUf>iFWDDCX#A@vG8|B&S*{s#P@;vZ`i ztCoKVwN3-5pEw+~SL8ST|5EMUE7w_(m$jHrZ@28k2@%=aJbFp0Iv;rc8=a}#jdg{y z?8MtZGU_;3cH$0TZ={?^9RPt1QFE3RIWO`*hw5vHbOZNC$ht17N29j-|7wk^=*w!T zTo`^1kwMJ+r*RsBSvNWPQQZ2mmv#9I)K!d679kCGIzy9J;`E5UtU None: def _on_hover_gutter_async(self, point: int) -> None: content = '' if self._lightbulb_line == self.view.rowcol(point)[0]: - content += code_actions_content(self._code_actions_for_selection) + content += code_actions_content(self._code_actions_for_selection, lightbulb=False) if userprefs().show_diagnostics_severity_level: diagnostics_with_config: list[tuple[ClientConfig, Diagnostic]] = [] diagnostics_by_session_buffer: list[tuple[SessionBufferProtocol, list[Diagnostic]]] = [] diff --git a/plugin/hover.py b/plugin/hover.py index f88ee1d47..26d48f82a 100644 --- a/plugin/hover.py +++ b/plugin/hover.py @@ -83,7 +83,7 @@ def link(self, point: int, view: sublime.View) -> str: ] -def code_actions_content(actions_by_config: list[CodeActionsByConfigName]) -> str: +def code_actions_content(actions_by_config: list[CodeActionsByConfigName], lightbulb: bool = True) -> str: formatted = [] for config_name, actions in actions_by_config: action_count = len(actions) @@ -95,8 +95,10 @@ def code_actions_content(actions_by_config: list[CodeActionsByConfigName]) -> st text = actions[0].get('title', 'code action') href = "{}:{}".format('code-actions', config_name) link = make_link(href, text) + lightbulb_html = '' \ + if lightbulb else '' formatted.append( - f'
Quick Fix: {link} {config_name}
') + f'
{lightbulb_html}{link} {config_name}
') return "".join(formatted) diff --git a/popups.css b/popups.css index 621bc11ea..8e7aad3e2 100644 --- a/popups.css +++ b/popups.css @@ -68,6 +68,9 @@ color: var(--foreground); padding: 0.5rem; } +.actions .lightbulb { + padding-right: 0.3rem; +} .actions a.icon { text-decoration: none; }