Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpstan errors #175

Open
4 tasks done
garthbrantley opened this issue Jun 17, 2023 · 2 comments
Open
4 tasks done

Fix phpstan errors #175

garthbrantley opened this issue Jun 17, 2023 · 2 comments
Assignees
@eugene-shab
Labels
codequality

Comments

@garthbrantley
Copy link
Member

garthbrantley commented Jun 17, 2023 •
edited
Loading

PRs: #262, #264, #265, #54, #266
Separate PR for each level of phpstan compliance.

  • Level 1
  • Level 2
  • Level 3
  • Level 4
@garthbrantley garthbrantley self-assigned this Jul 3, 2023
eugene-shab added a commit that referenced this issue Dec 19, 2023
@eugene-shab
feat: Fix PHPStan level 1.
75efe8b 
Refs: #175
@eugene-shab eugene-shab mentioned this issue Dec 19, 2023
Merged
eugene-shab added a commit that referenced this issue Dec 19, 2023
@eugene-shab
feat: Fix phpstan errors level 2.
6bbb4f3 
Refs: #175
@eugene-shab eugene-shab mentioned this issue Dec 19, 2023
Merged
eugene-shab added a commit that referenced this issue Dec 20, 2023
@eugene-shab
feat: Fix phpstan errors level 3.
b7a27d1 
Refs: #175
@eugene-shab eugene-shab mentioned this issue Dec 20, 2023
Merged
eugene-shab added a commit that referenced this issue Dec 20, 2023
@eugene-shab
feat: Additional Fix.
566616f 
Refs: #175
garthbrantley added a commit that referenced this issue Dec 20, 2023
@garthbrantley
Merge pull request #262 from subscribepro/175-fix-phpstan-errors-level-1
e3e062d 
#175 Fix phpstan errors level 1
garthbrantley added a commit that referenced this issue Dec 20, 2023
@garthbrantley
Merge pull request #264 from subscribepro/175-fix-phpstan-errors-level-2
5b035ef 
#175 Fix phpstan errors level 2
eugene-shab added a commit that referenced this issue Dec 20, 2023
@eugene-shab
feat: Fix PHPStan errors level 4.
40b9a8e 
Refs: #175
@eugene-shab eugene-shab mentioned this issue Dec 20, 2023
Merged
@eugene-shab
Copy link
Collaborator

eugene-shab commented Dec 20, 2023 •
edited
Loading

@garthbrantley Added fixes for 4 levels of PHPStan errors. The config (phpstan.neon) has also been added to the module root dir.
Instructions for using PHPStan were added to the Readme file.

Fixed scope for DataObject in the library (separate pull request)

garthbrantley added a commit that referenced this issue Jan 15, 2024
@garthbrantley
Merge pull request #265 from subscribepro/175-fix-phpstan-errors-level-3
a808fe2 
#175 Fix phpstan errors level 3
garthbrantley added a commit that referenced this issue Jan 15, 2024
@garthbrantley
Merge pull request #266 from subscribepro/175-fix-phpstan-errors-level-4
0ce8753 
#175 Fix phpstan errors level 4
@garthbrantley
Copy link
Member Author

@eugene-shab Still needs more work. We want to pass:

  • bin/analyze --level=4 src/app/code/Swarming/SubscribePro
  • when the extension is installed inside Mark Shust docker stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugene-shab eugene-shab

Labels
codequality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eugene-shab @garthbrantley