Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS2 Challenge content does not fit - Wallet, Checkout #224

Open
garthbrantley opened this issue Nov 25, 2023 · 6 comments
Open

3DS2 Challenge content does not fit - Wallet, Checkout #224

garthbrantley opened this issue Nov 25, 2023 · 6 comments
Assignees

Comments

@garthbrantley
Copy link
Member

garthbrantley commented Nov 25, 2023

PRs: #231, #271

Some challenge content is different sizes. Need to support different sizes.

Solution

  • Use <iframe> with 390px x 400px contents (This is challengeWindowSize = 2, which is now our platform default)
  • Allow scrollbars on iframe if content exceeds those dimensions

Docs about 3DS2 authentication request args

We are currently passing 03 (meaning 500x600 challenge window).

These are the supported options we can pass when initiating:

Field Name Type Description
ChallengeWindowSize* numeric Determines size of the challenge window.
1 - 250x400
2 - 390x400
3 - 500x600
4 - 600x400
5 - Full Screen (allows for responsive design)

Adyen defaults to 05, meaning 390px x 400px

Issue Report

This is documented on the wallet page.

Presumably the same issue would occur during checkout.

image

@eugene-shab
Copy link
Collaborator

@garthbrantley I can't change the size of the iframe content because I don't have access to it. I increased the height of the iframe itself. Now we need to ask to change the location of the border in this iframe for cards of type PA Y, since when increasing the size the border remained in place

image

image

@eugene-shab
Copy link
Collaborator

@garthbrantley I don't see ChallengeWindowSize property in payment-fields.js. I even decompress payment-fields.js and I didn't find this property also.

@garthbrantley
Copy link
Member Author

@eugene-shab Please:

  • Use <iframe> with 390px x 400px contents (This is challengeWindowSize = 2, which is now our platform default)
  • Allow scrollbars on iframe if content exceeds those dimensions

@eugene-shab
Copy link
Collaborator

@garthbrantley

  • After my investigation, I found that I can't add scroll to the iframe because iframe content has overflow: hidden.

Image

  • I don't see how I can use ChallengeWindowSize in our js.

@garthbrantley
Copy link
Member Author

Try using 390px x 400px contents (this is challengeWindowSize = 2).

However make the actualy iframe inside dimensions 590px x 600px. Apprarently there tends to be 100px padding on all sides.

I would also like to run a test using challengeWindowSize = 5, a "full-screen" / responsive version. I will be modifying the PaymentFields hosted widget to support passing the challengeWindowSize as a configuration option.

@eugene-shab
Copy link
Collaborator

@garthbrantley
Changed iframe size to 590px x 600px.

garthbrantley added a commit that referenced this issue Jan 15, 2024
…size

#224 3DS2 Challenge content does not fit - Wallet, Checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants