Don't display subscribe_pro methods in instant purchase when method not allowed for one-time purchase and not creating a subscription

[chrismshea]

PR: #269

That's a mouthful, but:
In Magento 2 the Subscribe Pro payment method should be disabled for one time purchases.

In Magento 2 Instant Purchase button on Product Detail Page is enabled by default.

So, when one time purchase is disabled should we only allow the Instant Purchase button to display when customer is subscribing or if they have a saved card that is not subscribe_pro.

[eugene-shab]

@chrismshea
Did I understand you correctly, if the config one-time purchase is set as false

If we have saved the SP payment method:

• for One Time Delivery Instance Purchase should be hidden
• for Regular Delivery Instance Purchase should be shown

If we have saved non-SP payment method:

• for One Time Delivery Instance Purchase should be shown
• for Regular Delivery Instance Purchase should be hidden

[chrismshea]

I think we need one more category:
If you have a saved sp and non sp method.

• for One Time Delivery Instant Purchase should show non-SP payment method
• for Regular Delivery Instance Purchase should be shown with SP payment method

I'm not sure how to change what profile is used for instant purchase and I have not seen a selector when the modal pops up.

[eugene-shab]

@chrismshea @garthbrantley
I added functionality for processing Instant Purchase buttons and a modal popup when the config Enabled for Non-Subscription Transactions is disabled.

Magento on the default behavior for the Instant Purchases button calls the last available Payment Method Token from the vault_payment_token table.

I have doubts about some cases:

1. If the SP payment method is enabled, what should the behavior be on a Non-Subscription product? At the moment the SP method token is substituted in the Instant Purchase modal.
2. If the SP payment method is disabled, what behavior should the Subscription product have? Currently if selected:
   • One Time Delivery Instant Purchase button is shown (Non-SP payment method enabled - e.x Braintree)
   • Regular Delivery Instant Purchase button is not shown

[chrismshea]

Instant Purchase Requires:

• Logged In Customer
• Stored Default Address
• Stored Payment Method
• Have Logged Out, and Back In after meeting the above requirements. Also could have completed a checkout with saved card.
• if storing a new card in My Account you will need to log out and back in before that latest card is chosen in Instant Purchase.