feat: version compat checking in build #1791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: n/version-check
|
nhtyy
force-pushed
the
n/version-check
branch
from
da9a84d
to
704d689
Compare
yuwen01
reviewed
Nov 20, 2024
There was a problem hiding this comment.
https://crates.io/crates/cargo-lock
Is there a reason we're parsing the cargo.lock by hand instead of using this crate?
| pub(crate) fn build_program_internal(path: &str, args: Option<BuildArgs>) { | ||
| // Get the root package name and metadata. | ||
| let program_dir = std::path::Path::new(path); | ||
| verify_locked_version(program_dir).expect("locked version mismatch"); |
There was a problem hiding this comment.
Can you make this error message more descriptive? As someone reading this error message, I don't understand what is mismatched between lock files.
There was a problem hiding this comment.
So with the expect also displaying the inner error msg I think its sufficent wdyt
ex: locked version mismatch: Locked version of sp1-sdk is incompatible with the current toolchain version
or itll say zkvm depending on the mismatch
nhtyy
force-pushed
the
n/version-check
branch
from
4c7f6c9
to
4a26afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version checking the
sp1-zkvmcrate with the current toolchain to ensure compatibly.Assumes that major/minor of
sp1-zkvmandsp1-buildmatching implies compat, which would be inline ifsp1-zkvminherits workspace version in the futureedit: closes #1625