Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider holding a unique_ptr to the Document Window *inside* melatonin_inspector.h #83

Open
sudara opened this issue Sep 6, 2023 · 2 comments
Labels

Comments

@sudara
Copy link
Owner

sudara commented Sep 6, 2023

Pros:

  • Simplifies installation instructions (applications just hold a normal member, no need for users to make_unique or define onClose)
  • Could attach key listener attached to root app so ctrl/cmd-I constructs and opens the inspector

@FigBug Do you care at all? Mainly motivated for the key command, I can also just add on my app side.

@sudara sudara added the UI label Sep 6, 2023
@sudara
Copy link
Owner Author

sudara commented Sep 6, 2023

Also might help do some work on the way to #56

@FigBug
Copy link
Collaborator

FigBug commented Sep 6, 2023

I'm not too picky how the api looks, as long as I can have my menu item that creates / destroys the inspector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants