Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a crash (function call may happen on deleted object) #123

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

gondre
Copy link
Contributor

@gondre gondre commented Aug 26, 2024

No description provided.

@sudara
Copy link
Owner

sudara commented Aug 26, 2024

Thanks for the contribution!

Could you provide some details about how to reproduce the crash?

@gondre
Copy link
Contributor Author

gondre commented Aug 26, 2024

I just added that include to my PluginEditor.h:
#include "melatonin_inspector/melatonin_inspector.h"

and the inspector to the members:
melatonin::Inspector inspector { *this };

The bug happened the first time I opened the plugin, using the vst3 in Reaper on macOS.
I fixed it immediately, so I'm not sure if it's reproducible all the time or not.
IIRC Reaper may create the editor twice in a row when instantiating the plugin, so I guess the callAfterDelay probably occurred right after the first created editor had been destroyed.

@sudara
Copy link
Owner

sudara commented Aug 26, 2024

Ok, thanks, that's very helpful!

@sudara sudara merged commit ac5595d into sudara:main Aug 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants