Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: schema.json wrong epoch definition #24

Open
rureverek opened this issue Apr 6, 2023 · 0 comments
Open

bug: schema.json wrong epoch definition #24

rureverek opened this issue Apr 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rureverek
Copy link
Contributor

{"name": "epoch", "cType": "d"}

This line caused bug in telemetry unpacking on intermediate server side.

In telemetry software it's convenient to use unsigned int as epoch number, not double like is defined here. Epoch value is actually timer tick number which is also int.
Double size is 8 bytes in python.struct whereas int is 4 bytes and this was the origin of issue.

So I recommend to change this to unsigned integer:
{"name": "epoch", "cType": "I"}

Note: This change may cause problems with intermediate server's telemetry emulation so recommend to review intermediate server's code before pushing this change.
@AndreasDemenagas @t-bre

@rureverek rureverek added the bug Something isn't working label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant