You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This line caused bug in telemetry unpacking on intermediate server side.
In telemetry software it's convenient to use unsigned int as epoch number, not double like is defined here. Epoch value is actually timer tick number which is also int. Double size is 8 bytes in python.struct whereas int is 4 bytes and this was the origin of issue.
So I recommend to change this to unsigned integer: {"name": "epoch", "cType": "I"}
Note: This change may cause problems with intermediate server's telemetry emulation so recommend to review intermediate server's code before pushing this change. @AndreasDemenagas@t-bre
The text was updated successfully, but these errors were encountered:
can-defs/tsgen/__main__.py
Line 311 in bf9edac
This line caused bug in telemetry unpacking on intermediate server side.
In telemetry software it's convenient to use
unsigned int
as epoch number, notdouble
like is defined here. Epoch value is actually timer tick number which is alsoint
.Double
size is 8 bytes in python.struct whereasint
is 4 bytes and this was the origin of issue.So I recommend to change this to unsigned integer:
{"name": "epoch", "cType": "I"}
Note: This change may cause problems with intermediate server's telemetry emulation so recommend to review intermediate server's code before pushing this change.
@AndreasDemenagas @t-bre
The text was updated successfully, but these errors were encountered: