Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Change dbc namings #32

Open
Avdieienko opened this issue Jan 27, 2025 · 0 comments
Open

refactor: Change dbc namings #32

Avdieienko opened this issue Jan 27, 2025 · 0 comments
Labels
good first issue Good for newcomers refactor Rewriting/restructuring code without changing behaviour

Comments

@Avdieienko
Copy link
Member

Avdieienko commented Jan 27, 2025 •
edited
Loading

Current Implementation

  1. All messages in CAN-C use Mxxx naming.
  2. BMS messages in CAN-S has no naming (e.g. MSGID_0x203)

Proposed Improvement

  1. These messages are related to PM100(inverter) and should be renamed to PM100_{name}, substituting Mxxx occurrences.
  2. Rename to make it clear that these are BMS messages

Additional Notes

Don't use tsgen unless this issue is resolved.
@Avdieienko Avdieienko added good first issue Good for newcomers refactor Rewriting/restructuring code without changing behaviour labels Jan 27, 2025
@Avdieienko Avdieienko changed the title refactor: Change namings for CAN-C refactor: Change dbc namings Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Rewriting/restructuring code without changing behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Avdieienko