From 584009376f51621e524521ab8ef971a25de70698 Mon Sep 17 00:00:00 2001 From: Ethan <47520067+Skelmis@users.noreply.github.com> Date: Tue, 27 Feb 2024 18:43:23 +1300 Subject: [PATCH] fix: remove information disclosure via queue approval (#78) --- suggestions/objects/suggestion.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/suggestions/objects/suggestion.py b/suggestions/objects/suggestion.py index 06dcb0a..ea04c70 100644 --- a/suggestions/objects/suggestion.py +++ b/suggestions/objects/suggestion.py @@ -925,11 +925,16 @@ async def setup_initial_messages( log.debug("Created a thread on suggestion %s", self.suggestion_id) try: + suggestion_author = ( + f"<@{self.suggestion_author_id}>" + if comes_from_queue + else interaction.author.mention + ) embed: disnake.Embed = disnake.Embed( description=bot.get_locale( "SUGGEST_INNER_SUGGESTION_SENT", interaction.locale ).format( - interaction.author.mention, + suggestion_author, channel.mention, self.suggestion_id, ),