fix: anon being shown in thread ping

suggestionsbot · Mar 29, 2024 · 7e2d630 · 7e2d630
1 parent 68b617f
commit 7e2d630
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -14,3 +14,4 @@
 - [ ] Guild config method names aren't duplicated
 - [ ] New localizations have been added
 - [ ] Documentation on ``docs.suggestions.gg`` has been updated
+- [ ] Do these changes make sure not to expose anonymous suggestion authors?
diff --git a/suggestions/objects/suggestion.py b/suggestions/objects/suggestion.py
@@ -698,6 +698,10 @@ async def create_thread(self, message: disnake.Message, *, ih: InteractionHandle
         thread = await message.create_thread(
             name=f"Thread for suggestion {self.suggestion_id}"
         )
+        if self.is_anonymous:
+            # Dont expose the anon author
+            return
+
         try:
             await thread.send(
                 ih.bot.get_localized_string(