fix: remove information disclosure via queue approval

suggestionsbot · Feb 27, 2024 · e222dbd · e222dbd
1 parent cee879e
commit e222dbd
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/suggestions/objects/suggestion.py b/suggestions/objects/suggestion.py
@@ -925,11 +925,16 @@ async def setup_initial_messages(
                 log.debug("Created a thread on suggestion %s", self.suggestion_id)
 
         try:
+            suggestion_author = (
+                f"<@{self.suggestion_author_id}>"
+                if comes_from_queue
+                else interaction.author.mention
+            )
             embed: disnake.Embed = disnake.Embed(
                 description=bot.get_locale(
                     "SUGGEST_INNER_SUGGESTION_SENT", interaction.locale
                 ).format(
-                    interaction.author.mention,
+                    suggestion_author,
                     channel.mention,
                     self.suggestion_id,
                 ),