fix: queue approver disclosure #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skelmis
added a commit
that referenced
this pull request
Mar 11, 2024
* chore: initial commit * Adds interaction handler class (#76) * chore: change readme * feat: add InteractionHandler class (#64) * feat: add InteractionHandler class * feat: add tests for the class * chore: run tests on all branches * chore: make actions nicer to remove duplicate runs * fix: tests * fix: tests * fix: remove information disclosure via queue approval (#78) * fix: suggestion message race condition * Update pt_BR.json to version 3.20 (#68) * Update pt_BR.json to version 3.20 * Update PULL_REQUEST_TEMPLATE.md * Suggestion queue update --------- Co-authored-by: Ethan <[email protected]> * fix: json file format * fix: images 404'ing (#79) * feat: physical suggestions queue (#77) * fix: InteractionHandler tests * feat: move current suggestions queue to use interaction handler * feat: port existing queue rejection/approval to new generic method * fix: virtual queue approval and rejection system * feat: add initial physical queue * fix: messages being sent * fix: error message for missing queue channel * feat: add items to /config get * fix: tests * chore: make button styling more obvious * chore: rename physical queue to channel queue * chore: fix wording * feat: move to logoo logging (#80) * feat: start logoo integration * chore: remove un-needed metadata * feat: migrate to Logoo * chore: shush httpx logs * feat: add bot_version to logs * chore: bump logoo version --------- Co-authored-by: Davi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the fact you can see who approved your suggestion from within the queue
Checklist
stats.suggestions.ggdocs.suggestions.gghas been updated