Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use _.merge in place of _.assign #2

Open
ipsips opened this issue Sep 6, 2017 · 0 comments
Open

Should use _.merge in place of _.assign #2

ipsips opened this issue Sep 6, 2017 · 0 comments

Comments

@ipsips
Copy link

ipsips commented Sep 6, 2017

https://github.com/sumul/fractal-react-adapter/blob/master/src/adapter.js#L99

Otherwise it's not possible to specify custom plugins via babelConfig, eg:

const reactAdapter = require('fractal-react-adapter')({
  babelConfig: {
    extensions: ['.jsx'],
    presets: ['es2015', 'es2017', 'stage-3', 'react'],
    plugins: ['transform-class-properties']
  }
});

Or use _.merge on the entire DEFAULT_OPTIONS: https://github.com/sumul/fractal-react-adapter/blob/master/src/adapter.js#L117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant