Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data getter in Suspense component has side effects #28

Open
elwayman02 opened this issue Jun 2, 2021 · 1 comment
Open

data getter in Suspense component has side effects #28

elwayman02 opened this issue Jun 2, 2021 · 1 comment

Comments

@elwayman02
Copy link
Collaborator

elwayman02 commented Jun 2, 2021 •
edited
Loading

https://github.com/sunishsheth2009/ember-async-component/blob/master/addon/components/suspense/index.js#L81-L85
@elwayman02
Copy link
Collaborator Author

@sunishsheth2009 do you have any thoughts on how we can remove those two sets from this getter? Can we somehow turn task and promise into their own getters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elwayman02