Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set time attribute #77

Open
hayesla opened this issue Oct 24, 2022 · 1 comment
Open

Ability to set time attribute #77

hayesla opened this issue Oct 24, 2022 · 1 comment

Comments

@hayesla
Copy link
Member

hayesla commented Oct 24, 2022

Describe the feature

For doing comparisons between multiple spacecraft at different AU (e.g. solo, psp) you may want to adjust time for light travel time for comparisons of timing etc.

Use case - plot RPW and PSP data on same plot and adjust for light travel between the two.

At the moment, if you try update the spec.times attribute, something like

spec.times = spec_times + light_travel_time
you get the AttributeError: can't set attribute error.

It would be nice to be able to do this - thoughts on allowing a method to update it?

@samaloney
Copy link
Contributor

Yea I guess like map don't really want to alter the meta data but need to allow this some how. Long term what I really want it something like:

with spectrogram.assumeLightTravel(spec1.observer):
    spec2.plot()

but what could maybe be done now would be something like:

with spectrogram.assumeLightTravel(-100*u.s):
    spec2.plot()

what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants