One of these functions is not like the others

[GillySpace27]

Basically, in the sunkit-image.radial module, the exported functions are all "full, stand-alone" algorithms except for the "set attenuation coefficients" function, which is just a helper for the FNRGF algorithm.

`all = ["fnrgf", "intensity_enhance", "set_attenuation_coefficients", "nrgf", "rhef"]

I would suggest that the parameters could just be passed in as arguments to the main algorithm, rather than having an extra public function. Could also be handled by importing from the utils file, for ease of understanding.

sunkit-image/sunkit_image/radial.py

Lines 13 to 18 in f7df502

	__all__ = [
	"fnrgf",
	"intensity_enhance",
	"set_attenuation_coefficients",
	"nrgf",
	]

Tasks

Preview Give feedback

No tasks being tracked yet.

[nabobalis]

Yeah, that is good idea!

[Abinash-bit]

#243 fixes this.

[Abinash-bit]

@nabobalis @GillySpace27