Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 🐐 counter #410

Merged
merged 7 commits into from
Apr 6, 2024
Merged

Test 🐐 counter #410

merged 7 commits into from
Apr 6, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Apr 6, 2024

🐐

conf.py Outdated Show resolved Hide resolved
requirements.txt Outdated
@@ -1,6 +1,6 @@
# RC versions are needed as netfily does not support modern python
ablog>=0.11.0rc1
sunpy-sphinx-theme>=2.0.0rc1
sunpy-sphinx-theme>=2.0.8rc1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we merge this we should remove the rc as having it here means it will install any rc which probably isn't what we want in normal operation.

Co-authored-by: Nabil Freij <[email protected]>
@Cadair Cadair marked this pull request as ready for review April 6, 2024 20:08
requirements.txt Outdated Show resolved Hide resolved
@Cadair Cadair requested a review from nabobalis April 6, 2024 20:13
@Cadair Cadair merged commit 9947629 into sunpy:main Apr 6, 2024
8 of 9 checks passed
@Cadair Cadair deleted the rc_theme branch April 6, 2024 20:16
@@ -1,6 +1,6 @@
# RC versions are needed as netfily does not support modern python
ablog>=0.11.0rc1
sunpy-sphinx-theme>=2.0.0rc1
sunpy-sphinx-theme>=2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump this no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants