feat: enable all supported extensions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnr
reviewed
Aug 27, 2024
There was a problem hiding this comment.
This is great, thanks @mnahkies! This looks good, but I'm going to wait on merging this until we sort out some details with deployments. We are looking into the ability to deploy in-browser databases to the cloud and want to make sure that the cloud environment is also going to support these extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enables all supported extensions from https://pglite.dev/extensions/
What is the current behavior?
See #82
What is the new behavior?
It can now successfully create schemas / run queries that make use of extensions.
Additional context
I didn't add a migration to
CREATE EXTENSION ...like is present forpgvectoras I observed that the AI was able to figure out this is needed and do so on demand, which seems better.There doesn't seem to be much overhead from doing this, but YMMV.