-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server related tests? #7
Comments
It's been a long time, but in case this is of any use: There are all kinds of async tests in there, but it just uses this.wait jasmine has async support: and I usually test javascript async stuff using promises. that is the fastest way, but sc has no promises. |
That's a good example. I wondered because recently you said that the tests that require starting a server would slow down travis too much. |
We should be polite and concerned. Also it seems crazy to run all of this every time someone changes a help file. |
Maybe we should add such tasks to a different quark which is only executed at royal occasions? |
also: Commits that have [ci skip] anywhere in the commit messages are ignored by Travis CI. |
good to know. |
Right now, server tests aren't run on travis, and won't be able to be run without some serious configuration work (either (1) get some kind of proxy jack daemons running on the travis machines, or (2) refactor server tests to also be usable in an NRT context - preferably 1 with some of 2). It's probably more worthwhile to get the tests actually running in the first place, rather than spending the time to plan around a problem that doesn't exist yet. We would be in FANTASTIC shape if we had enough unit tests that we actually had to worry about how long they took .... |
And, fyi, repackaging to a different quark isn't required to filter what's run on travis. The test suites run on ci builds is defined here: https://github.com/supercollider/supercollider/blob/master/travis_test_run_proto.json |
Not sure how we should handle server related tests.
Here are doneAction tests, not yet in the form required. But where to put them?
The text was updated successfully, but these errors were encountered: