Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for Device in DMX.fade #1

Open
kflak opened this issue Aug 25, 2021 · 0 comments
Open

Add check for Device in DMX.fade #1

kflak opened this issue Aug 25, 2021 · 0 comments

Comments

@kflak
Copy link

kflak commented Aug 25, 2021

It would be great to check if a device is not nil before launching a fade, especially when working with "mixed" project, where light is an optional part of the setup. I could probably sit down and do a PR for this next week, when I have a bit more time, but it would be good to get a couple of ideas on how to go about it in the most generic way possible. I'm thinking just to wrap the body of the fade method with an nil check for device. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant