Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Search bar #1324

Open
2 tasks
yanivbh1 opened this issue Sep 19, 2023 · 9 comments
Open
2 tasks

Feature request: Search bar #1324

yanivbh1 opened this issue Sep 19, 2023 · 9 comments

Comments

@yanivbh1
Copy link
Contributor

yanivbh1 commented Sep 19, 2023

Description

A simple search bar with the ability to run a query and search a string throughout all Memphis entities, including stations, messages, producers, tags, consumer groups, consumers, schemas, etc.

  • Add a search icon to the main dashboard

Screenshot 2023-10-25 at 12 54 59
Primary

  • Clicking the button should open a modal box with the following design.
    Screenshot 2023-10-25 at 12 59 17
@Rahulcheerio
Copy link

Any UI for this ?

@yanivbh1
Copy link
Contributor Author

@Rahulcheerio Attaching.
Are you willing to take the back of it as well?

@yanivbh1
Copy link
Contributor Author

@Rahulcheerio , attached in the issue description

@Exar04
Copy link

Exar04 commented Jan 14, 2024

hey i am working on this and I am almost done doing it
Screenshot 2024-01-15 at 2 58 56 AM
Screenshot 2024-01-15 at 2 59 12 AM

I had a question that what api call that i need to make to get names of stations, messages, producers ...

@Exar04
Copy link

Exar04 commented Jan 15, 2024

which one looks better?
1 ->
Screenshot 2024-01-15 at 2 58 56 AM

2->
Screenshot 2024-01-15 at 11 43 56 AM

@Exar04
Copy link

Exar04 commented Jan 15, 2024

Hey right now i am done doing following functionalities on this

Features added -
search icon
search bar
no items will be shown unless something typed in input field
exit search on clicking outside search box
scroll bar
smooth transition on hover
auto focus on search bar
search functionality

what remained is -
getting data by doing api calls
adding icon for consumers, producers and tags

Are there any icons that can be used?
Screenshot 2024-01-15 at 6 13 50 PM

@yanivbh1
Copy link
Contributor Author

which one looks better? 1 -> Screenshot 2024-01-15 at 2 58 56 AM

2-> Screenshot 2024-01-15 at 11 43 56 AM

Looks great @Exar04 !
Option 1, to make it bolder.

Regarding the icons, you chose the right ones according to the screenshot.

@Exar04
Copy link

Exar04 commented Jan 15, 2024

Made search Icon bold -
Screenshot 2024-01-15 at 8 40 12 PM

and about icons, i have found icons for station, schema, message but there are no icons to represent producer and consumer. if there are any please let me know.

@Exar04
Copy link

Exar04 commented Jan 17, 2024

hey @yanivbh1 , i have added most of the functionality only remaining part is getting producer, consumer and messages.
but first I thing i should make a pr and get the code reviewed, cuz its my first time to this repo and i probably have written spaghetti code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants