Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications to Discord #1069

Open
yanivbh1 opened this issue Jul 4, 2023 · 10 comments · May be fixed by #1507
Open

Notifications to Discord #1069

yanivbh1 opened this issue Jul 4, 2023 · 10 comments · May be fixed by #1507

Comments

@yanivbh1
Copy link
Contributor

yanivbh1 commented Jul 4, 2023

Description

Add support in pushing Memphis notifications to Discord with configuration through the Integration Center.

Important to know

  • To avoid rate limitations, a buffer should be implemented and push notifications in batches.
@yanivbh1 yanivbh1 added good first issue Good for newcomers epic: Broker epic: Integration Integration center labels Jul 4, 2023
@Avitaltrifsik
Copy link
Contributor

Hey @yanivbh1 could you please add a description to this issue?

@yanivbh1
Copy link
Contributor Author

@Avitaltrifsik should be ok.

@StarscourgeVelkhana
Copy link

@yanivbh1
Hey Yaniv. I'm currently on this issue and would need some more information where the discord notifications could be sent. Options I think of:

  • Send discord notification as a private message
  • Send discord notification to a server channel
  • Send discord notifications to multiple server channels
  • Send discord notification to multiple servers and specified channels

One more question:
Where do you guys store sensitive data. I will have to integrate the bot token somewhere.

@yanivbh1
Copy link
Contributor Author

Hey @StarscourgeVelkhana ,
I would say either private or server channels. Multiple would be preferred.
Creds are saved encrypted within the metadata store, which is a vanilla Postgres.

@StarscourgeVelkhana
Copy link

StarscourgeVelkhana commented Jul 17, 2023

Alright.
Only multiple channels or also multiple servers (and channels)?

What I mean: Can the bot be added only to one server or multiple

@yanivbh1
Copy link
Contributor Author

Single server, multiple channels.
Thank you for your help @StarscourgeVelkhana !

@turulix
Copy link
Contributor

turulix commented Jul 31, 2023

Wouldn't it be easier to just use Webhooks instead of making an entire bot for it?

@yanivbh1
Copy link
Contributor Author

That’s a much better idea @turulix

@yanivbh1
Copy link
Contributor Author

@StarscourgeVelkhana what do you think?

@yanivbh1
Copy link
Contributor Author

The feature is available for contribution.

@bodevone bodevone linked a pull request Dec 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants