feat: updated error codes/messages and related tests

supertokens · Sep 4, 2023 · e940dfe · e940dfe
1 parent 291524d
commit e940dfe
Show file tree

Hide file tree

Showing 20 changed files with 137 additions and 51 deletions.
diff --git a/lib/build/emailpassword-shared6.js b/lib/build/emailpassword-shared6.js
diff --git a/lib/build/passwordless-shared3.js b/lib/build/passwordless-shared3.js
diff --git a/lib/build/recipe/emailpassword/components/themes/translations.d.ts b/lib/build/recipe/emailpassword/components/themes/translations.d.ts
diff --git a/lib/build/recipe/passwordless/components/themes/translations.d.ts b/lib/build/recipe/passwordless/components/themes/translations.d.ts
diff --git a/lib/build/recipe/thirdparty/components/themes/translations.d.ts b/lib/build/recipe/thirdparty/components/themes/translations.d.ts
diff --git a/lib/build/recipe/thirdparty/index.d.ts b/lib/build/recipe/thirdparty/index.d.ts
diff --git a/lib/build/recipe/thirdpartyemailpassword/components/themes/translations.d.ts b/lib/build/recipe/thirdpartyemailpassword/components/themes/translations.d.ts
diff --git a/lib/build/recipe/thirdpartyemailpassword/index.d.ts b/lib/build/recipe/thirdpartyemailpassword/index.d.ts
diff --git a/lib/build/recipe/thirdpartypasswordless/components/themes/translations.d.ts b/lib/build/recipe/thirdpartypasswordless/components/themes/translations.d.ts
diff --git a/lib/build/recipe/thirdpartypasswordless/index.d.ts b/lib/build/recipe/thirdpartypasswordless/index.d.ts
diff --git a/lib/build/thirdparty-shared2.js b/lib/build/thirdparty-shared2.js
diff --git a/lib/ts/recipe/emailpassword/components/themes/translations.ts b/lib/ts/recipe/emailpassword/components/themes/translations.ts
@@ -80,7 +80,7 @@ export const defaultTranslationsEmailPassword = {
         "Password must contain at least one alphabet": undefined,
         "Password must contain at least one number": undefined,
         "Email is invalid": undefined,
-        "Token generation was not done because of account take over risk. Please contact support. (HAS_OTHER_EMAIL_OR_PHONE)":
+        "Reset password link was not created because of account take over risk. Please contact support. (ERR_CODE_001)":
             undefined,
     },
 };
diff --git a/lib/ts/recipe/passwordless/components/themes/translations.ts b/lib/ts/recipe/passwordless/components/themes/translations.ts
@@ -79,7 +79,9 @@ export const defaultTranslationsPasswordless = {
         "Failed to generate a one time code. Please try again": undefined,
         "Phone number is invalid": undefined,
         "Email is invalid": undefined,
-        "Cannot sign in / up due to security reasons. Please contact support. (IS_SIGN_UP_ALLOWED_FALSE)": undefined,
-        "Cannot sign in / up due to security reasons. Please contact support. (IS_SIGN_IN_ALLOWED_FALSE)": undefined,
+        "Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_002)":
+            undefined,
+        "Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_003)":
+            undefined,
     },
 };
diff --git a/lib/ts/recipe/thirdparty/components/features/signInAndUpCallback/index.tsx b/lib/ts/recipe/thirdparty/components/features/signInAndUpCallback/index.tsx
@@ -62,7 +62,7 @@ const SignInAndUpCallback: React.FC<PropType> = (props) => {
                     history: props.history,
                     queryParams: {
                         error: response.status,
-                        message: "reason" in response ? response.reason : response.status,
+                        message: response.reason,
                     },
                     redirectBack: false,
                 });

diff --git a/lib/ts/recipe/thirdparty/components/themes/translations.ts b/lib/ts/recipe/thirdparty/components/themes/translations.ts
@@ -15,16 +15,19 @@ export const defaultTranslationsThirdParty = {
         THIRD_PARTY_PROVIDER_DEFAULT_BTN_END: "",
 
         THIRD_PARTY_ERROR_NO_EMAIL: "Could not retrieve email. Please try a different method.",
-        EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT:
-            "Cannot sign in / up due to security reasons. Please contact support. (EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT)",
 
         /*
          * The following are error messages from our backend SDK.
          * These are returned as full messages to preserver compatibilty, but they work just like the keys above.
          * They are shown as is by default (setting the value to undefined will display the raw translation key)
          */
-        "Cannot sign in / up due to security reasons. Please contact support. (IS_SIGN_IN_ALLOWED_FALSE)": undefined,
-        "Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ANOTHER_PRIM_USER_HAS_EMAIL)":
+
+        "Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_004)":
+            undefined,
+        "Cannot sign in / up because new email cannot be applied to existing account. Please contact support. (ERR_CODE_005)":
+            undefined,
+
+        "Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_006)":
             undefined,
     },
 };
diff --git a/lib/ts/recipe/thirdparty/index.ts b/lib/ts/recipe/thirdparty/index.ts
@@ -103,11 +103,11 @@ export default class Wrapper {
               fetchResponse: Response;
           }
         | {
-              status: "NO_EMAIL_GIVEN_BY_PROVIDER" | "EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT";
+              status: "NO_EMAIL_GIVEN_BY_PROVIDER";
               fetchResponse: Response;
           }
         | {
-              status: "SIGN_IN_UP_NOT_ALLOWED";
+              status: "SIGN_IN_UP_NOT_ALLOWED" | "EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT";
               reason: string;
               fetchResponse: Response;
           }

diff --git a/lib/ts/recipe/thirdpartyemailpassword/index.ts b/lib/ts/recipe/thirdpartyemailpassword/index.ts
@@ -216,11 +216,11 @@ export default class Wrapper {
               fetchResponse: Response;
           }
         | {
-              status: "NO_EMAIL_GIVEN_BY_PROVIDER" | "EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT";
+              status: "NO_EMAIL_GIVEN_BY_PROVIDER";
               fetchResponse: Response;
           }
         | {
-              status: "SIGN_IN_UP_NOT_ALLOWED";
+              status: "SIGN_IN_UP_NOT_ALLOWED" | "EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT";
               reason: string;
               fetchResponse: Response;
           }

diff --git a/lib/ts/recipe/thirdpartypasswordless/index.ts b/lib/ts/recipe/thirdpartypasswordless/index.ts
@@ -78,11 +78,11 @@ export default class Wrapper {
               fetchResponse: Response;
           }
         | {
-              status: "NO_EMAIL_GIVEN_BY_PROVIDER" | "EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT";
+              status: "NO_EMAIL_GIVEN_BY_PROVIDER";
               fetchResponse: Response;
           }
         | {
-              status: "SIGN_IN_UP_NOT_ALLOWED";
+              status: "SIGN_IN_UP_NOT_ALLOWED" | "EMAIL_ALREADY_USED_IN_ANOTHER_ACCOUNT";
               reason: string;
               fetchResponse: Response;
           }