Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Testing of Examples - Request for JSON API Endpoint #17

Open
lucasavila00 opened this issue Jun 20, 2021 · 0 comments
Open

Visual Testing of Examples - Request for JSON API Endpoint #17

lucasavila00 opened this issue Jun 20, 2021 · 0 comments

Comments

@lucasavila00
Copy link

lucasavila00 commented Jun 20, 2021

Visual Snapshot Tests are a great feature to use when working with storybooks.

I feel surface catalogue could work really well with that.

One great way to accomplish that is using the awesome jest-image-snapshot

I created a sample MR of what it would take to have something like that working with Catalogue: surface-ui/surface_bootstrap#9

If the approach of using jest-image-snapshot + puppeteer was taken, surface_catalogue should expose a JSON endpoint with all available examples, and their metadata, I think, and the jest script could handle all else.


If catalogue were to recommend some form of CI tests using the snapshots, I believe it should recommend using a docker image with puppetter and chrome (like the ones provided by browserless), to control system fonts and browser version.

@lucasavila00 lucasavila00 changed the title Visual Testing Visual Testing of Examples - Request for JSON API Endpoint Jun 20, 2021
@davydog187 davydog187 mentioned this issue Sep 3, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant