Knockout: Text for carry forward choices are not changed immediately …

…on changing survey locale fix #8367 (#8368)
surveyjs · Jun 5, 2024 · 83ddd47 · 83ddd47
1 parent b06e513
commit 83ddd47
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/question_baseselect.ts b/src/question_baseselect.ts
@@ -151,6 +151,9 @@ export class QuestionSelectBase extends Question {
       ItemValue.locStrsChanged(this.choicesFromUrl);
       ItemValue.locStrsChanged(this.visibleChoices);
     }
+    if(this.isUsingCarryForward) {
+      ItemValue.locStrsChanged(this.visibleChoices);
+    }
   }
   public get otherValue(): string {
     if(!this.showCommentArea) return this.comment;

diff --git a/tests/question_baseselecttests.ts b/tests/question_baseselecttests.ts
@@ -1276,6 +1276,12 @@ QUnit.test("Carry Forward and localization, bug#6352", function (assert) {
   assert.equal(q2.visibleChoices.length, 1);
   assert.deepEqual(q2.visibleChoices[0].locText.getJson(), { default: "A de", en: "A en" });
   assert.equal(q2.visibleChoices[0].text, "A en");
+  let counter = 0;
+  q2.visibleChoices[0].locText.onStringChanged.add((sender, options) => {
+    counter ++;
+  });
+  survey.locale = "de";
+  assert.equal(counter, 1, "Fire str changed");
   surveyLocalization.defaultLocale = "en";
 });
 QUnit.test("Carry Forward and keepIncorrectValues, bug#6490", function (assert) {