Support custom icons with oldNames

surveyjs · Sep 9, 2024 · a807257 · a807257
1 parent 67c37bf
commit a807257
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/packages/survey-core/src/utils/utils.ts b/packages/survey-core/src/utils/utils.ts
@@ -164,9 +164,20 @@ function wrapUrlForBackgroundImage(url: string): string {
   return !!url ? ["url(", url, ")"].join("") : "";
 }
 
+//new-name: old-name
+const renamedIcons = {
+  "folder": "chooseFile"
+};
+
 function getIconNameFromProxy(iconName: string): string {
   if (!iconName) return iconName;
   var proxyName = (<any>settings.customIcons)[iconName];
+  if(!proxyName) {
+    const oldName = renamedIcons[iconName];
+    if(!!oldName) {
+      proxyName = (<any>settings.customIcons)[oldName];
+    }
+  }
   return !!proxyName ? proxyName : iconName;
 }
 

diff --git a/packages/survey-core/tests/components/actionbartests.ts b/packages/survey-core/tests/components/actionbartests.ts
@@ -44,6 +44,17 @@ QUnit.test(
   }
 );
 
+QUnit.test(
+  "Support old customIcons names in svg, function getIconNameFromProxy",
+  (assert) => {
+    settings.customIcons["chooseFile"] = "new-chooseFile";
+    assert.equal(getIconNameFromProxy("chooseFile"), "new-chooseFile");
+    assert.equal(getIconNameFromProxy("folder"), "new-chooseFile");
+    assert.equal(getIconNameFromProxy("folder-new"), "folder-new");
+    delete settings.customIcons["chooseFile"];
+  }
+);
+
 QUnit.test(
   "isVisible",
   (assert) => {