From c41787e7c86c135c3de3743a9578aa01ba99c817 Mon Sep 17 00:00:00 2001
From: Dmitry <dk981234@gmail.com>
Date: Tue, 24 Oct 2023 10:37:24 +0400
Subject: [PATCH] Vue3: Fix onAfterRenderQuestion and
 onAfterRenderQuestionInput are fired with null html element (#7216)

* Work for #7173: fix ref is not passed for some questions in Vue 3

* Work for #7173: fix onAfterRenderQuestion is not fired when quesiton is lazy rendered
---
 packages/survey-vue3-ui/src/BooleanSwitch.vue |  1 +
 packages/survey-vue3-ui/src/Checkbox.vue      |  4 +-
 .../survey-vue3-ui/src/DropdownSelect.vue     |  2 +-
 packages/survey-vue3-ui/src/Element.vue       | 15 ++++-
 packages/survey-vue3-ui/src/File.vue          |  2 +-
 src/vue/element.vue                           | 22 ++++++--
 testCafe/survey/afterRenderEvent.ts           | 56 +++++++++++++++++++
 7 files changed, 91 insertions(+), 11 deletions(-)
 create mode 100644 testCafe/survey/afterRenderEvent.ts

diff --git a/packages/survey-vue3-ui/src/BooleanSwitch.vue b/packages/survey-vue3-ui/src/BooleanSwitch.vue
index d34046cf2f..d04b6325c4 100644
--- a/packages/survey-vue3-ui/src/BooleanSwitch.vue
+++ b/packages/survey-vue3-ui/src/BooleanSwitch.vue
@@ -1,6 +1,7 @@
 <template>
   <div
     :class="question.cssClasses.root"
+    ref="root"
     v-on:keydown="question.onKeyDownCore($event)"
   >
     <label :class="question.getItemCss()">
diff --git a/packages/survey-vue3-ui/src/Checkbox.vue b/packages/survey-vue3-ui/src/Checkbox.vue
index df7b321d34..10b70950cd 100644
--- a/packages/survey-vue3-ui/src/Checkbox.vue
+++ b/packages/survey-vue3-ui/src/Checkbox.vue
@@ -1,5 +1,7 @@
 <template>
-  <fieldset :class="question.getSelectBaseRootCss()" 
+  <fieldset
+    :class="question.getSelectBaseRootCss()"
+    ref="root"
     :role="question.a11y_input_ariaRole"
     :aria-required="question.a11y_input_ariaRequired"
     :aria-label="question.a11y_input_ariaLabel"
diff --git a/packages/survey-vue3-ui/src/DropdownSelect.vue b/packages/survey-vue3-ui/src/DropdownSelect.vue
index 4cf31d73b7..c437d9b63d 100644
--- a/packages/survey-vue3-ui/src/DropdownSelect.vue
+++ b/packages/survey-vue3-ui/src/DropdownSelect.vue
@@ -1,5 +1,5 @@
 <template>
-  <div :class="question.renderCssRoot">
+  <div :class="question.renderCssRoot" ref="root">
     <div :class="question.cssClasses.selectWrapper">
       <select
         v-if="!question.isReadOnly"
diff --git a/packages/survey-vue3-ui/src/Element.vue b/packages/survey-vue3-ui/src/Element.vue
index c752652329..0ee27723a7 100644
--- a/packages/survey-vue3-ui/src/Element.vue
+++ b/packages/survey-vue3-ui/src/Element.vue
@@ -88,7 +88,7 @@ import type {
   PanelModel,
 } from "survey-core";
 import { useBase } from "./base";
-import { computed, onMounted, ref } from "vue";
+import { computed, onMounted, onUnmounted, ref, watch } from "vue";
 
 const props = defineProps<{
   survey: SurveyModel;
@@ -119,9 +119,18 @@ const getContentClass = (element: Question) => {
 
 useBase(() => props.element);
 
-onMounted(() => {
-  if (!props.element.isPanel) {
+const afterRender = () => {
+  if (!props.element.isPanel && root.value) {
     (props.element as Question).afterRender(root.value as HTMLElement);
   }
+};
+const stopWatch = watch(
+  () => root.value,
+  () => {
+    afterRender();
+  }
+);
+onUnmounted(() => {
+  stopWatch();
 });
 </script>
diff --git a/packages/survey-vue3-ui/src/File.vue b/packages/survey-vue3-ui/src/File.vue
index 4ad919912c..5ecdd77ba4 100644
--- a/packages/survey-vue3-ui/src/File.vue
+++ b/packages/survey-vue3-ui/src/File.vue
@@ -1,5 +1,5 @@
 <template>
-  <div :class="question.fileRootCss">
+  <div :class="question.fileRootCss" ref="root">
     <input
       :class="question.cssClasses.fileInput"
       v-if="!question.isReadOnly && question.hasFileUI"
diff --git a/src/vue/element.vue b/src/vue/element.vue
index 8bce6f9ff4..b0e82495f6 100644
--- a/src/vue/element.vue
+++ b/src/vue/element.vue
@@ -1,6 +1,7 @@
 <template>
   <div :class="!element.isPanel ? element.getRootCss() : null" 
         v-if="row.isNeedRender"
+        ref="root"
         v-on:focusin="element.focusIn()"
         :id="element.id"
         :role="element.ariaRole"
@@ -66,6 +67,7 @@
   
   <component
   v-else-if="!!element.skeletonComponentName"
+  ref="root"
   :is="element.skeletonComponentName"
   :element="element"
   :css="css"
@@ -74,7 +76,7 @@
 
 <script lang="ts">
 import Vue from "vue";
-import { Component, Prop } from "vue-property-decorator";
+import { Component, Prop, Watch } from "vue-property-decorator";
 import { Base, SurveyModel, Question, QuestionRowModel } from "survey-core";
 import { getComponentName } from "./question";
 import { BaseVue } from "./base";
@@ -100,12 +102,22 @@ export class SurveyElementVue extends BaseVue {
   get hasErrorsOnBottom() {
     return !this.element.isPanel && (<Question>this.element).showErrorOnBottom;
   }
-  mounted() {
-    if (!this.element.isPanel) {
-      (<Question>this.element).afterRender(this.$el as HTMLElement);
+  previousElement: HTMLElement;
+  afterRender(el: HTMLElement) {
+    if (!this.element.isPanel && this.previousElement !== el && el && el instanceof HTMLElement) {
+      (<Question>this.element).afterRender(el);
     }
+    this.previousElement = el;
+  }
+  onUpdated() {
+      this.afterRender(this.$refs.root as HTMLElement);
+  }
+  mounted(): void {
+    this.afterRender(this.$refs.root as HTMLElement)
+  }
+  destroyed(): void {
+    this.previousElement = undefined as any;
   }
-
 }
 Vue.component("survey-element", SurveyElementVue);
 export default SurveyElementVue;
diff --git a/testCafe/survey/afterRenderEvent.ts b/testCafe/survey/afterRenderEvent.ts
new file mode 100644
index 0000000000..80ab478361
--- /dev/null
+++ b/testCafe/survey/afterRenderEvent.ts
@@ -0,0 +1,56 @@
+import { ClientFunction, Selector } from "testcafe";
+import { frameworks, url_test, initSurvey } from "../helper";
+
+const title = "afterRenderQuestionEvent";
+
+const json = {
+  pages: [
+    {
+      name: "page1",
+      title: "page one",
+      elements: [
+        {
+          type: "radiogroup",
+          name: "q1",
+          choices: ["1", "2", "3"],
+        },
+        {
+          type: "text",
+          visibleIf: "{q1} = '1'",
+          name: "q2",
+          isRequired: true,
+        },
+        {
+          type: "text",
+          name: "q3",
+        },
+        {
+          type: "text",
+          name: "q4",
+        }
+      ],
+    },
+  ],
+};
+
+frameworks.forEach((framework) => {
+  fixture`${framework} ${title}`.page`${url_test}defaultV2/${framework}`.beforeEach(async (t) => {
+    await t.resizeWindow(1920, 1080);
+  });
+  test("afterRender is not fired when questions are lazy rendered", async (t) => {
+    await ClientFunction(() => {
+      (window as any).Survey.settings.lazyRowsRendering = true;
+    })();
+    const f = (survey, options) => {
+      options.htmlElement.setAttribute("test", true);
+    };
+    const events = { onAfterRenderQuestion: f };
+    await initSurvey(framework, json, events);
+
+    await t.click(Selector("label").nth(0))
+      .expect(Selector("div[data-name='q1']").hasAttribute("test")).ok()
+      .expect(Selector("div[data-name='q2']").hasAttribute("test")).ok()
+      .expect(Selector("div[data-name='q3']").hasAttribute("test")).ok()
+      .expect(Selector("div[data-name='q4']").hasAttribute("test")).ok();
+  });
+});