JSON Schema contains incorrect property

[SamMousa]

Describe the bug
Starting in version .16 (works in .15) the JSON generated JSON schema from const surveySchemas = SurveyCore.Serializer.generateSchema();
incorrectly contains a required type property Panel and descendants (like Page).

Steps to reproduce

https://plnkr.co/edit/597fb2fRoToMekq5

Expected behavior
The JSON schema should not have this property.

[andrewtelnov]

@SamMousa Your example was incorrect. I have created a new one. Could you please point what is exactly wrong here?
Page is inherited from Panel now. It allows to render Page as a Panel when needed without re-creating the object itself.

Thank you,
Andrew

[SamMousa]

Could you please point what is exactly wrong here?

Yes, if you look at the panel definition it has a required property type:

However if you go the survey builder and switch to JSON, the page has no type property. (I think it's an artifact of the Serializer)

In our application we use Monaco Editor and validate the JSON schema, which is how I discovered this bug:

Randomly spotted another error:

I don't think isSinglePage is or should be a property in JSON (since it is a derived value from questionsOnPageMode).

[andrewtelnov]

@SamMousa Page is inherited from Panel, so it doesn't need to have type, like QuestionText doesn't have type, but Question does.
The problem with isSinglePage is solved by PR above. We should not add non-serializable properties.

Thank you,
Andrew

[SamMousa]

But type is also not a serializable property for page, correct?

[andrewtelnov]

Yes, I think it makes sense to remove it for panel as well. We don't need it for panel as well.

[andrewtelnov]

I removed it by another commit into the same PR.

Thank you,
Andrew