Fix duplicating br tags in html (#356)

surveyjs · Nov 29, 2024 · 31f5686 · 31f5686
1 parent b63ec8b
commit 31f5686
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/flat_layout/flat_html.ts b/src/flat_layout/flat_html.ts
@@ -24,7 +24,7 @@ export class FlatHTML extends FlatQuestion {
     }
 
     private static correctHtmlRules: [{ searchRegExp: RegExp, replaceString: string }] = [
-        { searchRegExp: /(<\/?br\s*?\/?\s*?>\s*){2,}/, replaceString: '<br>' }
+        { searchRegExp: /(<\/?br\s*?\/?\s*?>\s*){2,}/g, replaceString: '<br>' }
     ]
     protected correctHtml(html: string): string {
         FlatHTML.correctHtmlRules.forEach((rule) => {

diff --git a/tests/flat_html.test.ts b/tests/flat_html.test.ts
@@ -86,6 +86,8 @@ test('Check correctHtml method with multiple br tags', async () => {
     const htmlFlat = new FlatHTML(survey, new QuestionHtmlModel('q1'), controller);
     expect(htmlFlat['correctHtml']('<span>Test</span><br>')).toEqual('<span>Test</span><br>');
     expect(htmlFlat['correctHtml']('<span>Test</span><br><br>')).toEqual('<span>Test</span><br>');
+    expect(htmlFlat['correctHtml']('<br><br><span>Test</span><br><br>')).toEqual('<br><span>Test</span><br>');
+    expect(htmlFlat['correctHtml']('<br><br><span>Test</span><br><br><br><span>Test</span><br><br>')).toEqual('<br><span>Test</span><br><span>Test</span><br>');
     expect(htmlFlat['correctHtml']('<span>Test</span><br>  <br>')).toEqual('<span>Test</span><br>');
     expect(htmlFlat['correctHtml']('<br><span>Test</span><br>')).toEqual('<br><span>Test</span><br>');
     expect(htmlFlat['correctHtml']('<br><br/>')).toEqual('<br>');