-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MetalLB chart #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kristian-ZH
force-pushed
the
add-metallb-chart
branch
2 times, most recently
from
August 10, 2023 11:16
ffe22b9
to
7eccb32
Compare
e-minguez
requested changes
Aug 10, 2023
Kristian-ZH
force-pushed
the
add-metallb-chart
branch
from
August 11, 2023 09:42
7eccb32
to
b8e761f
Compare
Kristian-ZH
force-pushed
the
add-metallb-chart
branch
from
August 24, 2023 12:22
b8e761f
to
1f09bcb
Compare
e-minguez
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions but those can be sorted out in a follow up PR. I've created #29 to track them.
Kristian-ZH
force-pushed
the
add-metallb-chart
branch
from
September 5, 2023 08:26
1f09bcb
to
4389a37
Compare
Kristian-ZH
added a commit
to Kristian-ZH/charts
that referenced
this pull request
Sep 25, 2023
Co-authored-by: Kristian Zhelyazkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MetalLB charts with custom images
TODO: The Docker images sources should be changed once the EDGE team creates their own OBS workspace