Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding metadata to 'gammas' (and other files) #24

Open
erelson opened this issue Jan 5, 2013 · 2 comments
Open

Adding metadata to 'gammas' (and other files) #24

erelson opened this issue Jan 5, 2013 · 2 comments

Comments

@erelson
Copy link
Contributor

erelson commented Jan 5, 2013

I have added support* for comment lines (using #) at the top of the 'gammas' file, but have not implemented automatically creating this comment yet. The basis for doing this is to supply a bit of extra information for when someone looks at the gammas file at some later date (Andy's idea, back in September, I think). The contents I have in mind for this comment/header line are:

  • timestamp
  • cooling time
  • isotope
  • problem title
  • ?? other ideas?

The problem title would be analogous to MCNP's title card, and would be specified as a new parameter in the r2s.cfg file.

Is the problem title unnecessary? Do we want this concept added to other files in the workflow? (e.g. alara_input, phtn_src)

*support, as in, source.F90 simply skips over these lines

@ghost ghost assigned erelson Jan 5, 2013
@elliottbiondo
Copy link
Collaborator

That all sounds very good. I do think the problem title would be a useful addition. For example, in my Shine work l do a single neutron calculation, but then I break up the problem to different source regions for separate photon transport calcs. Each one of these regions has its own r2s.cfg, so being able to give each a title would be nice. In any case, you can just supply a generic default value like "r2s-act problem" and it won't be any burden to the user.

@erelson
Copy link
Contributor Author

erelson commented Jan 13, 2013

This is currently implemented so that the r2s_step2.py script passes the isotope and cooling step to write_gammas.py. Passing a title will work as well - just another keyword parameter in the function call. source_gammas.F90 handles comment lines, as already mentioned.

Still need to note this feature in documentation, and add tests for the updated code.

erelson added a commit that referenced this issue Jan 15, 2013
Chose to skip over the metadata header line, as it is nonessential to functionality. See also #24.
@erelson erelson removed their assignment Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants